Disable media-router by default

[jumde]

Description

Cast initiates SSDP requests by default. Cast should be disabled by default, add a setting to enable cast.

More details here: #5057 (comment)

Just a note for history: Android currently doesn't have an option and cast is always on there. We have to fix it allowing Android to cast still. That's the original issue for Android #13898

Test Plan

Specified here: brave/brave-core#9987

[kjozwiak]

Removing OS/Android as this will be verified on Android via #17972.

[GeetaSarvadnya]

Verification passed on

Brave | 1.29.80 Chromium: 93.0.4577.63 (Official Build) (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

• Verified the test plan from Fix #17873 - Disable media router by default (uplift to 1.29.x) brave-core#10007

Verified that the Cast option is not available in the hamburger menu by default and SSDP requests are not initiated on start

Enabled Media Router in brave://settings/extensions and confirmed Cast menu option is shown in the hamburger menu

Open a youtube.com video and clicked on Cast option in the hamburger menu and confirmed there is no crash and No device found message is shown as no device are connected to cast the video

---

Verification passed on

Brave	1.29.80 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision	ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#10020

Verified Media Router is disabled by default in brave://settings/extensions

Verified that the Cast option is not available in the hamburger menu by default

Verified after enabling Media Router in brave://settings/extensions, Cast was added to Hamburger menu

Opened a youtube.com video and clicked on Cast option in the hamburger menu and confirmed there is no crash and No device found message is shown

---

Verified PASSED using

Brave	1.29.80 Chromium: 93.0.4577.63 (Official Build) (x86_64)
Revision	ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS	macOS Version 11.5.2 (Build 20G95)

Verified test plan from brave/brave-core#10020

Verified Media Router is disabled by default in brave://settings/extensions

Verified that the Cast option is not available in the hamburger menu by default

Verified after enabling Media Router in brave://settings/extensions, Cast was added to Hamburger menu

Opened https://www.youtube.com/watch?v=qpacG2GxuDA and clicked on Cast option in the hamburger menu and confirmed there is no crash, casting works

[reyesvicente]

Encountered this just now. I just opened Brave Browser and this popped up.

[GeetaSarvadnya]

cc: @stephendonner

[stephendonner]

Encountered this just now. I just opened Brave Browser and this popped up.

Please file a new issue with steps to reproduce and as much info as you can. (cc me on it, please).

I installed Lulu and have Media Router disabled and don't see anything with mediacast popping up on Lulu.