Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipfs: and ipns: protocol associations #13266

Closed
da2x opened this issue Dec 21, 2020 · 2 comments · Fixed by brave/brave-core#7864
Closed

Add ipfs: and ipns: protocol associations #13266

da2x opened this issue Dec 21, 2020 · 2 comments · Fixed by brave/brave-core#7864

Comments

@da2x
Copy link

da2x commented Dec 21, 2020

Description

Brave should register with the host OS as a handler for ipfs: and ipns: URIs.

Steps to Reproduce

  • (On Windows): Press Win+R, type ipfs://bafkreigcnxudvpojjfwncmauociy5q46zsq46oe66cxbyzie3imabuoege, and press Enter
  • (On macOS): Open the Terminal, and type open ipfs://bafkreigcnxudvpojjfwncmauociy5q46zsq46oe66cxbyzie3imabuoege, and press Enter.
  • (On Linux): Open a shell and type xdg-open ipfs://bafkreigcnxudvpojjfwncmauociy5q46zsq46oe66cxbyzie3imabuoege

Expected result:

Brave should open and display a page with the word “PASS” on it.

Actual result:

Variations on an error saying no app can open the link.

Reproduces how often:

Every time.

Brave version (brave://version info)

87.1.19.62

Version/Channel Information:

Beta

Miscellaneous Information:

  • On Linux, append MimeType=x-scheme-handler/ipfs;MimeType=x-scheme-handler/ipns; to MimeType= in the Brave.desktop file.
  • On macOS, append ipfs: and ipns: to the CFBundleURLSchemes array in Info.plist.
  • On Windows, add the missing schemes through Microsoft’s convoluted registry process.
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 10, 2021
@ingokeck
Copy link

Please note that this is not the correct URI syntax. There should not be a '//' in the URI if the resource is just an IPFS hash like in this case. Please see #13677 for details.

@spylogsster spylogsster self-assigned this Feb 5, 2021
@rebron rebron changed the title Add ipfs: and ipns: protocol asscoiations Add ipfs: and ipns: protocol associations Feb 9, 2021
@bbondy bbondy added this to the 1.22.x - Nightly milestone Feb 12, 2021
@stephendonner
Copy link

stephendonner commented Feb 22, 2021

Verified FIXED on nightly using the steps to reproduce given in the original comment, with:

Brave 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS macOS Version 11.2.1 (Build 20D74)

Screen Shot 2021-02-22 at 2 17 34 PM

Note also, as already mentioned, that #13677 is open for correcting the URI(s).


Verification passed on

Brave 1.22.53 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image


Verification passed on

Brave | 1.22.56 Chromium: 89.0.4389.72 (Official Build) dev (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Verified the test plan from the description

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants