Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename web3 provider to Ethereum provider #11711

Closed
bbondy opened this issue Sep 14, 2020 · 2 comments · Fixed by brave/brave-core#6647
Closed

Rename web3 provider to Ethereum provider #11711

bbondy opened this issue Sep 14, 2020 · 2 comments · Fixed by brave/brave-core#6647

Comments

@bbondy
Copy link
Member

bbondy commented Sep 14, 2020

Description

Since windows.web3 is going away it doesn't make sense to call it a web3 provider anymore. We should call it an Ethereum provider.

Screen Shot 2020-09-14 at 3 14 26 PM

New text: Ethereum provider for using Dapps

Screen Shot 2020-09-14 at 3 15 33 PM

New text: Would you like to start Crypto Wallets for Ethereum support?

Test Plan

Just make sure chrome://settings in the Extension setting shows the right text. Also the infobar which comes up when you visit cryptokitties.co

@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Sep 14, 2020
@bbondy bbondy self-assigned this Sep 14, 2020
@srirambv srirambv changed the title Rename web3 provider to Ethereum provider [Desktop] Rename web3 provider to Ethereum provider Sep 15, 2020
@bbondy bbondy changed the title [Desktop] Rename web3 provider to Ethereum provider Rename web3 provider to Ethereum provider Sep 15, 2020
@bbondy bbondy added this to the 1.16.x - Nightly milestone Sep 15, 2020
@btlechowski
Copy link

Verification passed on

Brave 1.16.55 Chromium: 86.0.4240.72 (Official Build) dev (64-bit)
Revision 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Verified text was updated Ethereum provider for using Dapps in brave://settings/extensions:
image
image

Verified infobar on cryptokitties.co:
image
image

Verified Polish locale
image
image

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (x86_64)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified brave://settings/extensions is renamed to Ethereum provider for using Dapps
    image
  • Verified setup info bar has the changed text Would you like to start Crypto Wallets for Ethereum support?
    image

Verification passed on

Brave 1.16.59 Chromium: 86.0.4240.75 (Official Build) beta (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Windows 10 OS Version 1809 (Build 17763.1490)
  • Verified brave://settings/extensions is renamed to Ethereum provider for using Dapps
    image
  • Verified setup info bar has the changed text Would you like to start Crypto Wallets for Ethereum support?
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants