Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Reset Brave Rewards data is not translated in brave://settings/clearBrowserData #11244

Closed
btlechowski opened this issue Aug 15, 2020 · 1 comment

Comments

@btlechowski
Copy link

btlechowski commented Aug 15, 2020

Follow up to #926

Steps to Reproduce

  1. Enable Rewards
  2. Open brave://settings/clearBrowserData in Polish locale

Actual result:

Reset Brave Rewards data is not translated
image

Expected result:

Reset Brave Rewards data is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
Revision d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS Ubuntu 18.04 LTS
Brave 1.14.42 Chromium: 85.0.4183.59 (Official Build) nightly (64-bit)
Revision 7cc9a5ee672625c38427a839cb1b15efd3128084-refs/branch-heads/4183@{#1216}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @mkarolin @NejcZdovc @rebron

@btlechowski
Copy link
Author

btlechowski commented Aug 27, 2020

Fixed with #11395

Verification passed on

Brave 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

Verified STR from the description

image
image


Verification passed on


Brave | 1.13.82 Chromium: 85.0.4183.83 (Oficjalna wersja) (64-bitowa)
-- | --
Wersja | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
System operacyjny | Windows 10 OS Version 1903 (Build 18362.1016)


image
image
image


Verified passed with

Brave | 1.13.82 Chromium: 85.0.4183.83 (Oficjalna wersja) (64-bitowa)
-- | --
Wersja | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
System operacyjny | macOS Wersja 10.14.6 (kompilacja 18G3020)

Verified STR from description
Zrzut ekranu 2020-08-27 o 8 52 37 AM
Zrzut ekranu 2020-08-27 o 8 52 46 AM
Zrzut ekranu 2020-08-27 o 8 53 00 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants