Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change canvas maximum farbling to match balanced farbling #11067

Closed
pilgrim-brave opened this issue Aug 3, 2020 · 2 comments · Fixed by brave/brave-core#6324
Closed

Change canvas maximum farbling to match balanced farbling #11067

pilgrim-brave opened this issue Aug 3, 2020 · 2 comments · Fixed by brave/brave-core#6324
Assignees
@pilgrim-brave
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.12.x - Release #1

Comments

@pilgrim-brave
Copy link

As per internal discussion, to address user feedback, we have decided to change the behavior of canvas at maximum farbling to be the same as the balanced farbling behavior.
@pilgrim-brave pilgrim-brave self-assigned this Aug 3, 2020
@pilgrim-brave pilgrim-brave added the feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields label Aug 3, 2020
@pilgrim-brave pilgrim-brave mentioned this issue Aug 3, 2020
Merged
32 tasks
This was referenced Aug 4, 2020
Merged
Merged
@LaurenWags
Copy link
Member

LaurenWags commented Aug 7, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on


Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Verification passed on

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 7, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 7, 2020

Verification passed on OnePlus 6T with Android 10 running 1.12.109

  • Verified no artefacts are shown on the player when FP is set to block all

Verification passed on Samsung Tab A with Android 10 running 1.12.109

  • Verified no artefacts are shown on the player when FP is set to block all

@srirambv srirambv mentioned this issue Aug 11, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
@srirambv srirambv mentioned this issue Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Change canvas maximum farbling to match balanced farbling brave/brave-core
7 participants
@bbondy @kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya @pilgrim-brave