Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update macOS Installer Graphics #1105

Closed
rossmoody opened this issue Sep 12, 2018 · 6 comments · Fixed by brave/brave-core#2782
Closed

Update macOS Installer Graphics #1105

rossmoody opened this issue Sep 12, 2018 · 6 comments · Fixed by brave/brave-core#2782
Assignees
@simonhong
Labels
design A design change, especially one which needs input from the design team growth/engagement OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include setup/installer
Milestone
0.68.x - Release

Comments

@rossmoody
Copy link
Contributor

rossmoody commented Sep 12, 2018 •
edited by bsclifton
Loading

Description

Browser laptop had custom iconography for the mounted installer icon (at least on Mac) as well as the screen that results from needing to drag it manually to the Applications folder. We are currently serving stock instances of both. A stock installer icon and a stock Application window on OSX.

On Windows, as far as I can tell, a mounted icon doesn't appear and there is no prompt for a subsequent window like the process in OSX. I don't believe any further refinement is needed in the Windows install flow that isn't outlined in: #1101

Test plan / Steps to Reproduce

  1. Download any channel of Brave on OSX.
  2. Mount the dmg.
  3. View the stock installer icon.
  4. Click the installer icon and find the stock window iconography next to each other.

Actual result:

image

Intended Result

Installer icons tied to the release channel.

image

Custom Mounted Finder Window

image
@rossmoody rossmoody added design A design change, especially one which needs input from the design team setup/installer labels Sep 12, 2018
@rossmoody rossmoody added this to the 1.x Backlog milestone Sep 12, 2018
@rossmoody rossmoody self-assigned this Sep 12, 2018
@rossmoody rossmoody added the polish Nice to have — usually related to front-end/visual tasks label Sep 12, 2018
@rossmoody rossmoody removed their assignment Sep 13, 2018
@rossmoody rossmoody modified the milestones: 1.x Backlog, 1.0 Sep 15, 2018
@LaurenWags LaurenWags mentioned this issue Sep 20, 2018
Closed
@srirambv srirambv mentioned this issue Oct 11, 2018
Closed
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jan 22, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rossmoody rossmoody removed their assignment Feb 15, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Apr 12, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 12, 2019

cc: @bradleyrichter

@bradleyrichter
Copy link

Muon seems to have a more "pleasant surprise of customization" effect...

image

@rebron rebron added growth/engagement and removed polish Nice to have — usually related to front-end/visual tasks labels Apr 12, 2019
@rebron rebron added the OS/macOS label Jun 4, 2019
@rossmoody
Copy link
Contributor Author

Updated background graphic:
download-window

bsclifton referenced this issue in brave/brave-core Jun 13, 2019
@bsclifton
how do you add background image properly?!
54ee038
@bsclifton bsclifton assigned simonhong and unassigned bsclifton Jun 25, 2019
@simonhong
Copy link
Member

@rossmoody I'm working on this now. Can you attach volume icon files here for 4 channels?

@simonhong simonhong mentioned this issue Jun 25, 2019
Merged
32 tasks
@bsclifton bsclifton added this to the 0.69.x - Nightly milestone Jun 25, 2019
@bsclifton bsclifton changed the title Update Installer Graphics Update macOS Installer Graphics Jun 25, 2019
@brave-builds brave-builds mentioned this issue Jun 25, 2019
Merged
4 tasks
@LaurenWags
Copy link
Member

Verified passed with Brave-Browser-Beta.dmg on macOS x64 10.13.6

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Screen Shot 2019-08-01 at 3 59 24 PM

Verified passed with Brave-Browser-Dev.dmg on macOS x64 10.13.6

Brave 0.69.94 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Screen Shot 2019-08-01 at 4 02 47 PM

Verified passed with Brave-Browser-Nightly.dmg on macOS x64 10.13.6

Brave 0.70.22 Chromium: 76.0.3809.87 (Official Build) nightly (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Screen Shot 2019-08-01 at 4 05 02 PM

cc @kjozwiak for a second macOS check on Mojave

@kjozwiak kjozwiak mentioned this issue Aug 2, 2019
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Aug 7, 2019

Verification PASSED on macOS 10.14.5 x64 using the following builds:

Brave 0.70.43 Chromium: 76.0.3809.87 (Official Build) nightly (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Screen Shot 2019-08-07 at 12 05 45 AM

Screen Shot 2019-08-07 at 12 06 08 AM

Brave 0.69.100 Chromium: 76.0.3809.87 (Official Build) dev (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Screen Shot 2019-08-07 at 12 11 07 AM

Screen Shot 2019-08-07 at 12 11 12 AM

Brave 0.68.115 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Screen Shot 2019-08-07 at 12 13 20 AM

Screen Shot 2019-08-07 at 12 13 03 AM

@srirambv srirambv mentioned this issue Aug 8, 2019
Open
@LaurenWags LaurenWags mentioned this issue Aug 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
design A design change, especially one which needs input from the design team growth/engagement OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include setup/installer
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Update mac installer update brave/brave-core
8 participants
@bbondy @kjozwiak @bsclifton @rebron @simonhong @bradleyrichter @LaurenWags @rossmoody