"Ads notifications received this month" should only increment for views with a redemption value greater than 0.0

[tmancey]

Description

"Ads notifications received this month" should only increment for views with a redemption value greater than 0.0

Steps to Reproduce

1. Click or dismiss an ad that has a redemption value for a click or dismiss greater than 0.0 (will need adding server-side)

Actual result:

"Ad notifications received this month" is incremented

Expected result:

"Ad notifications received this month" should not increment

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[GeetaSarvadnya]

Blocked until the PR brave/brave-core#5751 is uplifted
for more info https://bravesoftware.slack.com/archives/C43LW5U2H/p1592560782311300?thread_ts=1592560491.310900&cid=C43LW5U2H

[GeetaSarvadnya]

PR #5751 is uplifted to 1.11.x hence removing QA blocked label

[LaurenWags]

Added QA/Blocked label - need assistance on this one - https://bravesoftware.slack.com/archives/C43LW5U2H/p1593628267348700?thread_ts=1593173388.321300&cid=C43LW5U2H

[LaurenWags]

Verified passed with

Brave | 1.11.85 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified STR from description using non-zero-catalog.txt

• Confirmed view (with estimated earnings of 0.3 BAT) was counted in my Ad notifications received this month but the dismiss (also worth estimated 0.3 BAT) was not included:

[20095:775:0702/160854.342957:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 1 unblinded payment tokens
[20095:775:0702/160854.343014:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[20095:775:0702/160854.343582:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 83cb9575-a280-4c05-ba8e-d769c31e6eae, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and view

[20095:775:0702/160900.125296:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 2 unblinded payment tokens
[20095:775:0702/160900.125348:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[20095:775:0702/160900.126397:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id b453d099-37d6-459d-8f2a-f990d70db94e, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and dismiss

• Confirmed view (with estimated earnings of 0.3 BAT) was counted in my Ad notifications received this month but the click and landed (also each worth estimated 0.3 BAT) were not included:

[20154:775:0702/161720.157914:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 1 unblinded payment tokens
[20154:775:0702/161720.157971:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[20154:775:0702/161720.158499:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id f93a5910-ece8-4d25-8d61-509dd1375e55, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and view

[20154:775:0702/161725.332128:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 2 unblinded payment tokens
[20154:775:0702/161725.332183:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[20154:775:0702/161725.332714:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id adf5f36f-df43-41d9-9ca2-0cf903fe4863, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and click

[20154:775:0702/161737.441432:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 3 unblinded payment tokens
[20154:775:0702/161737.441486:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[20154:775:0702/161737.441988:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 3e95d86f-92e8-4d5d-b541-f9f9563c40c8, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and landed

---

Verification passed on

Brave	1.11.89 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Ubuntu 18.04 LTS

• Verified test plan from description using non-zero-catalog.txt on staging

• Verified view (with estimated earnings of 0.3 BAT) was counted in my Ad notifications received this month but the dismiss (also worth estimated 0.3 BAT) was not included:

[15358:15358:0706/111809.489240:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 1 unblinded payment tokens
[15358:15358:0706/111809.495183:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 83da3676-936e-4525-a6ec-f0ee08d4256d, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and view

[15358:15358:0706/111816.335985:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 2 unblinded payment tokens
[15358:15358:0706/111816.336160:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id d31769d0-c31e-417d-9cdb-c888b7d17993, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and dismiss

• Verified view (with estimated earnings of 0.3 BAT) was counted in my Ad notifications received this month but the click and landed (also each worth estimated 0.3 BAT) were not included:

[15958:15958:0706/113114.019592:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 1 unblinded payment tokens
[15958:15958:0706/113114.020057:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id a3bc5de5-d870-4590-b1f5-5143c1a445d5, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and view

[15958:15958:0706/113117.045631:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 2 unblinded payment tokens
[15958:15958:0706/113117.045828:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id ab750396-1b8f-453e-a628-d18a91ac1493, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and click

[15958:15958:0706/113132.576309:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 3 unblinded payment tokens
[15958:15958:0706/113132.576455:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 611fd296-45bc-4354-9186-d9dde8824aed, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and landed

---

Verification passed on

Brave | 1.11.90 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | Windows 10 OS Version 1903 (Build 18362.900)

• Verified STR from description using non-zero-catalog.txt

• Confirmed view (with estimated earnings of 0.3 BAT) was counted in my Ad notifications received this month but the dismiss (also worth estimated 0.3 BAT) was not included:

[9148:140:0708/142755.144:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 1 unblinded payment tokens
[9148:140:0708/142755.144:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[9148:140:0708/142755.145:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 323ad523-34e7-4eb0-9e11-26017a186bc2, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and view

• Confirmed view (with estimated earnings of 0.3 BAT) was counted in my Ad notifications received this month but the dismiss (also worth estimated 0.3 BAT) was not included:

[19568:8828:0708/143752.601:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 2 unblinded payment tokens
[19568:8828:0708/143752.601:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[19568:8828:0708/143752.602:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id b5d71765-b383-492d-b8d8-cdd8a0f57b57, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and dismiss

[7780:10456:0708/144759.043:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 2 unblinded payment tokens
[7780:10456:0708/144759.043:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[7780:10456:0708/144759.043:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 7a5331a9-b978-4249-ac53-b597abc07aec, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and click

• Confirmed view (with estimated earnings of 0.3 BAT) was counted in my Ad notifications received this month but the click and landed (also each worth estimated 0.3 BAT) were not included:

[7780:10456:0708/144759.043:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 2 unblinded payment tokens
[7780:10456:0708/144759.043:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[7780:10456:0708/144759.043:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 7a5331a9-b978-4249-ac53-b597abc07aec, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and click

[23308:23836:0708/145648.207:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 1 unblinded payment tokens
[23308:23836:0708/145648.207:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[23308:23836:0708/145648.207:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 8ac7bdaa-58db-4783-aeeb-69b2e9fb1ece, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and view

[23308:23836:0708/145722.830:VERBOSE1:redeem_token.cc(376)] Added 1 unblinded payment token with an estimated redemption value of 0.3 BAT, you now have 3 unblinded payment tokens
[23308:23836:0708/145722.830:VERBOSE3:confirmations_impl.cc(748)] Saving confirmations state
[23308:23836:0708/145722.831:VERBOSE1:redeem_token.cc(404)] Successfully redeemed token with confirmation id 69a8090f-abc9-43e2-b0a0-ab61aef9f022, creative instance id 68bc0caf-04d2-425a-8865-1acd6cbb63f1 and landed