Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete confirmation #55

Merged
merged 2 commits into from
Jul 22, 2016
Merged

Delete confirmation #55

merged 2 commits into from
Jul 22, 2016

Conversation

brarcher
Copy link
Owner

Add a confirmation before deleting card

#53

@brarcher brarcher force-pushed the delete-confirmation branch 3 times, most recently from 7b00688 to 7657d15 Compare July 20, 2016 15:13
@brarcher
Copy link
Owner Author

Hello @airon90 and @PanderMusubi!

The following pull request adds a confirmation dialog before deleting a loyalty card. This results in adding the following strings:

<string name="confirm">Confirm</string>
<string name="deleteTitle">Remove Loyalty Card</string>
<string name="deleteConfirmation">Please confirm that you want to delete this card.</string>

Could you please provide translations for these two strings?

Thanks!

@PanderMusubi
Copy link

Dutch:

<string name="confirm">Bevestig</string>
<string name="deleteTitle">Verwijder kaart</string>
<string name="deleteConfirmation">Bevestig deze kaart te verwijderen.</string>

@airon90
Copy link
Contributor

airon90 commented Jul 21, 2016

Here my transations:

<string name="confirm">Conferma</string>
<string name="deleteTitle">Rimuovi carta fedeltà</string>
<string name="deleteConfirmation">Conferma che vuoi eliminare questa carta.</string>

Branden Archer added 2 commits July 22, 2016 07:56
Add a confirmation before deleting card
fe0bb7b 
#53
Attempt to force travis builds on non-container infrastructure
010b88d 
There is an issue with running the travis builds. The root
cause is unknown. Attempting to use the non-container
version of the infrastructure to see if the issue persists.
@brarcher
Copy link
Owner Author

Thanks, @PanderMusubi and @airon90!

@brarcher brarcher merged commit e32b40a into master Jul 22, 2016
@brarcher brarcher deleted the delete-confirmation branch July 22, 2016 12:04
@airon90
Copy link
Contributor

airon90 commented Jul 22, 2016

You're welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brarcher @PanderMusubi @airon90