-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: allow editing barcode type (and also the card number) #89
Comments
The application does have a way to edit the barcode. From the edit screen one would need to press the Enter Card button. The next screen allows one to type the desired card ID. All valid barcodes from that card ID are then generated, allowing the user to select which barcode best represents the one they are after. Why does the application do this? Why not let the user select the barcode type after typing in the number? At least for me I find that I do not know what the different barcode types are. If asked to pick from a dropdown I likely would pick the wrong one. Having a list of all the valid barcode types for the given card ID seemed more reasonable. What the application currently does not do is once one clicks on the Enter Card button from the edit screen the existing barcode is not auto-populated. That is, the user must type everything from scratch. Implementing the auto-populating would be fairly simple to do. Would having the field auto-populate with the existing card ID help? Or, is your request more fundamental? |
I think auto-populating the field is good enough, and seems to work for any use-case I can think about. I'd do just one step further: If "card id" is empty (i.e. inserting a new card), the button should be "enter card" (just like it is now. However, if we are editing a card, the button could be renamed to "edit card". That way, it would be intuitive that we can edit the number and the type. |
I like your suggestion. I'll update the button text to say 'edit card' if there is already an id. |
The auto-populating feature has been added some time ago, and I now got around to changing the text on the "Enter card" button to "Edit card" if the card already exist. Marking this issue as resolved. If you feel otherwise, let me know. |
There are some stores that provide a physical card with 1D-barcode, but they also provide the same number as a QR Code in their app (IKEA is one example). Thus, I'd like to be able to change the barcode type without having to re-enter the number.
The UI can behave like this:
Edit
button.Why is this needed? Because I can scan my physical 1D card into the app, but then I can't edit it. If I want to use a different kind (QR Codes are easier to scan, specially if the phone screen is not high-res), I have to manually type the number.
The text was updated successfully, but these errors were encountered: