From 5c64264fbd6c3cec84a2dfc0b020263863bcda93 Mon Sep 17 00:00:00 2001
From: usy <contact.usyless@gmail.com>
Date: Tue, 21 Oct 2025 20:06:30 +0100
Subject: [PATCH 1/2] fix: dpp::cluster::register_command with coroutine
 handler on windows

---
 include/dpp/cluster.h | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/include/dpp/cluster.h b/include/dpp/cluster.h
index 0e064ce27d..23c704bd8d 100644
--- a/include/dpp/cluster.h
+++ b/include/dpp/cluster.h
@@ -607,11 +607,12 @@ class DPP_EXPORT cluster {
 	 * @return bool Returns `true` if the command was registered successfully, or `false` if
 	 * the command with the same name already exists.
 	 */
-	template <typename F>
-	std::enable_if_t<std::is_same_v<std::invoke_result_t<F, const slashcommand_handler_t&>, dpp::task<void>>, bool>
-	register_command(const std::string& name, F&& handler){
+    template <std::invocable<const slashcommand_t&> F>
+    requires (dpp::awaitable_type<typename std::invoke_result<F, const slashcommand_t&>::type>)
+	bool register_command(const std::string& name, F&& handler) {
+		co_slashcommand_handler_t wrapped = std::forward<F>(handler);
 		std::unique_lock lk(named_commands_mutex);
-		auto [_, inserted] = named_commands.try_emplace(name, std::forward<F>(handler));
+		auto [_, inserted] = named_commands.try_emplace(name, std::move(wrapped));
 		return inserted;
 	};
 #endif

From 3e21b57e81b9dd7309d87373e1cebe33dbc9a134 Mon Sep 17 00:00:00 2001
From: usy <contact.usyless@gmail.com>
Date: Wed, 22 Oct 2025 03:41:59 +0100
Subject: [PATCH 2/2] ensure coro return is dpp::task<void> and non-coro return
 is void

---
 include/dpp/cluster.h | 16 ++++++++++------
 src/dpp/cluster.cpp   |  6 ------
 2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/include/dpp/cluster.h b/include/dpp/cluster.h
index 23c704bd8d..1d09fb4e91 100644
--- a/include/dpp/cluster.h
+++ b/include/dpp/cluster.h
@@ -587,7 +587,12 @@ class DPP_EXPORT cluster {
 	 * @return bool Returns `true` if the command was registered successfully, or `false` if
 	 * the command with the same name already exists
 	 */
-	bool register_command(const std::string& name, const slashcommand_handler_t handler);
+	template <typename F>
+	std::enable_if_t<utility::callable_returns_v<F, void, const slashcommand_t&>, bool> register_command(const std::string& name, F&& handler) {
+		std::unique_lock lk(named_commands_mutex);
+		auto [_, inserted] = named_commands.try_emplace(name, std::forward<F>(handler));
+		return inserted;
+	}
 
 	/**
 	 * @brief Get the number of currently active HTTP(S) requests active in the cluster.
@@ -607,14 +612,13 @@ class DPP_EXPORT cluster {
 	 * @return bool Returns `true` if the command was registered successfully, or `false` if
 	 * the command with the same name already exists.
 	 */
-    template <std::invocable<const slashcommand_t&> F>
-    requires (dpp::awaitable_type<typename std::invoke_result<F, const slashcommand_t&>::type>)
+	template <typename F>
+	requires (utility::callable_returns<F, dpp::task<void>, const slashcommand_t&>)
 	bool register_command(const std::string& name, F&& handler) {
-		co_slashcommand_handler_t wrapped = std::forward<F>(handler);
 		std::unique_lock lk(named_commands_mutex);
-		auto [_, inserted] = named_commands.try_emplace(name, std::move(wrapped));
+		auto [_, inserted] = named_commands.try_emplace(name, std::in_place_type<co_slashcommand_handler_t>, std::forward<F>(handler));
 		return inserted;
-	};
+	}
 #endif
 
 	/**
diff --git a/src/dpp/cluster.cpp b/src/dpp/cluster.cpp
index 272e642d81..1888dccdca 100644
--- a/src/dpp/cluster.cpp
+++ b/src/dpp/cluster.cpp
@@ -638,12 +638,6 @@ cluster& cluster::set_request_timeout(uint16_t timeout) {
 	return *this;
 }
 
-bool cluster::register_command(const std::string &name, const slashcommand_handler_t handler) {
-	std::unique_lock lk(named_commands_mutex);
-	auto [_, inserted] = named_commands.try_emplace(name, handler);
-	return inserted;
-}
-
 bool cluster::unregister_command(const std::string &name) {
 	std::unique_lock lk(named_commands_mutex);
 	return named_commands.erase(name) == 1;