[CLOSED] Convert numbers to strings, so StringMatch can match it.

[core-ai-bot]

Issue by sprintr
Sunday Jul 26, 2015 at 16:54 GMT
Originally opened as adobe/brackets#11484

---

Converts "number" values into strings so StringMatch.stringMatch can match it.

@abose This is critical to go with the release.

---

sprintr included the following code: https://github.com/adobe/brackets/pull/11484/commits

[core-ai-bot]

Comment by abose
Sunday Jul 26, 2015 at 17:53 GMT

---

@sprintr what are the repercussions if we do not have this? what will break/not break. Could you give more details about the problems this pr addresses.
@nethip

[core-ai-bot]

Comment by sprintr
Sunday Jul 26, 2015 at 17:57 GMT

---

"number" type preferences when stringMatch(ed) will through an undefined is not a function and also number type preferences were not matched because of this since stringMatch expects string values to match against a query.

Came across this while writing docs for #11200. Have sent them to you via slack.

[core-ai-bot]

Comment by abose
Sunday Jul 26, 2015 at 17:59 GMT

---

OK, that is serious in that it would break brackets when trying to edit preferences file?

[core-ai-bot]

Comment by sprintr
Sunday Jul 26, 2015 at 17:59 GMT

---

Run this in brackets console to see what error get produced.

var StringMatch = require("utils/StringMatch");
StringMatch.stringMatch(1024, "10", {  preferPrefixMatches: true });

Converting 1024 to string works fine.

[core-ai-bot]

Comment by sprintr
Sunday Jul 26, 2015 at 18:00 GMT

---

Yes it broke hints when I pressed enter. So this fixes that as well.

[core-ai-bot]

Comment by abose
Sunday Jul 26, 2015 at 18:14 GMT

---

Thanks@sprintr .
Re- GM an RC build is a tough thing to push to the stakeholders as it is an expensive/labour intensive process. Several teams(brackets-dev, Release engineering, LOC testing, international translation vendors) & Lot of manual testing is involved prior to an RC build of brackets.- so just wanted to give reasons to justify that.
@nethip has to make the call.
If we are trigerring a rew release, I would also like to nominate #11485 - Health logs for find / replace in files, instant search usage.

[core-ai-bot]

Comment by nethip
Monday Jul 27, 2015 at 03:54 GMT

---

@sprintr How often do the users run into this use case? I did not understand the workflow with the number preference. Could you tell me what are the exact steps to repro this (from the user point of view). As@abose mentioned, the release tasks are quite laborious. If the frequency of someone running this issue is very minimal, I would nominate this for the next release.

[core-ai-bot]

Comment by sprintr
Monday Jul 27, 2015 at 04:04 GMT

---

I don't know any ext using number preference but since brackets supported that even before this feature I believe we should support it here as well. Right now it is broken.

[core-ai-bot]

Comment by nethip
Monday Jul 27, 2015 at 04:07 GMT

---

@sprintr OK! Could you mention the exact repro steps? Let me speak to the team and take an opinion.

[core-ai-bot]

Comment by sprintr
Monday Jul 27, 2015 at 04:10 GMT

---

You can copy any number type preference from the wiki page "'Preference code hints for developers". I am on phone so can't give exact steps to repro this

[core-ai-bot]

Comment by sprintr
Monday Jul 27, 2015 at 06:10 GMT

---

@nethip Thanks for getting this in. When is the release scheduled?

[core-ai-bot]

Comment by nethip
Monday Jul 27, 2015 at 06:12 GMT

---

@sprintr No issues! Thanks for jumping in and fixing it. Really appreciate it. We are targeting today for doing the release.

[core-ai-bot]

Comment by sprintr
Monday Jul 27, 2015 at 06:22 GMT

---

It was nice to get this in time.