[CLOSED] Resize events consolidation and minor resizer bugs (#2079)

[core-ai-bot]

Issue by jbalsas
Friday Nov 09, 2012 at 19:56 GMT
Originally opened as adobe/brackets#2092

---

This pull request consolidates the resize events dispatched by utils/Resizer following the comments on (#2079).

It also fixes some minor resizer bugs such as the one described in #2079 where after dragging the panel shut, it will expand to 10px instead of the original size.

@peterflynn Let me know if this is closer to what you'd expect

---

jbalsas included the following code: https://github.com/adobe/brackets/pull/2092/commits

[core-ai-bot]

Comment by peterflynn
Thursday Nov 15, 2012 at 00:46 GMT

---

Just tested the code a bit and the stream of events looks much cleaner now! I'll review the code itself now.

[core-ai-bot]

Comment by peterflynn
Thursday Nov 15, 2012 at 01:16 GMT

---

Done reviewing. Looks pretty solid overall -- thanks for posting the cleanup so fast!

[core-ai-bot]

Comment by jbalsas
Saturday Nov 17, 2012 at 00:31 GMT

---

@peterflynn Changes pushed. Ready for re-review.

Includes fix for #2117 as discussed (pending the mouse-glitch).

Doesn't fix the check for minSize in the preferences, which could be addressed in a separate issue.

[core-ai-bot]

Comment by peterflynn
Wednesday Nov 21, 2012 at 09:02 GMT

---

@jbalsas: Sorry I took so long to get back to you! This looks solid to me.

Re the min-size issue: your explanation makes sense to me. I don't think we should worry right now about the edge case of min-size increasing after a smaller value is already stored in prefs.

Re requesting animation frames in mousemove vs. at the end of doRedraw(): your latest code still requests at the end of each doRedraw() -- was that your intent? I think it's fine, myself... there's virtually no overhead from extra frames between mousemoves because of the newSize check.

[core-ai-bot]

Comment by jbalsas
Wednesday Nov 21, 2012 at 09:08 GMT

---

Don't worry!

About requesting animation frames, I was just testing different approaches to see if if it could still be improved a little. As you say, with the newSize check, the impact of doRedraw() is minimal, so I decided to leave it as is.

Feel free to merge this anytime ;)

[core-ai-bot]

Comment by peterflynn
Wednesday Nov 21, 2012 at 18:40 GMT

---

Sounds good to me -- merging