[CLOSED] Fixes #1256

[core-ai-bot]

Issue by DennisKehrig
Thursday Oct 04, 2012 at 13:49 GMT
Originally opened as adobe/brackets#1769

---

Fixes #1256: Deleting a file should remove entry from inline editor

This one could use a thorough review...

---

DennisKehrig included the following code: https://github.com/adobe/brackets/pull/1769/commits

[core-ai-bot]

Comment by RaymondLim
Monday Oct 08, 2012 at 22:20 GMT

---

Done with initial review.

[core-ai-bot]

Comment by DennisKehrig
Monday Oct 08, 2012 at 23:10 GMT

---

Thank you for the review! Much appreciated!

Personally I'm most skeptical about forwarding an event as the "cause" of another event. It feels fishy somehow. What are your thoughts on this?

[core-ai-bot]

Comment by RaymondLim
Monday Oct 08, 2012 at 23:19 GMT

---

I can't think of other elegant alternatives that will let you distinguish between "deleted" and "out-of-sync". So I'm ok with forwarding the "cause". It is harder to understand it at first. I was almost to question you on how we get "deleted" as the cause, but later I figured out by doing global search.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Oct 10, 2012 at 15:52 GMT

---

Thanks a lot for your review, much appreciated! I updated the comments as per your suggestions. Unless I overlooked anything, that's it from me for now.

[core-ai-bot]

Comment by RaymondLim
Wednesday Oct 10, 2012 at 16:08 GMT

---

Looks good. Merging