Skip to content

Commit

Permalink
Explain configure_git calls in bootstrap.sh
Browse files Browse the repository at this point in the history
The first call to `configure_git` is needed for cloning the repo.

The second call to `configure_git` is needed for CI use cases when
certain aspects of the `.gitconfig` cannot be used (like signing commits
with SSH). See commit c054239.
  • Loading branch information
br3ndonland committed Nov 5, 2023
1 parent 0442aa0 commit b54eafb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions bootstrap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ configure_git() {
fi
}

# The first call to `configure_git` is needed for cloning the dotfiles repo.
configure_git

# Check for and install any remaining software updates
Expand Down Expand Up @@ -380,6 +381,9 @@ log "Checking out $strap_dotfiles_branch_name in ~/.dotfiles."
run_dotfile_scripts scripts/symlink.sh
logk

# The second call to `configure_git` is needed for CI use cases when certain
# aspects of the `.gitconfig` cannot be used (like signing commits with SSH).
# See commit c0542397e817fc1bd711984619eb73a6fdc937b2.
configure_git

# shellcheck disable=SC2086
Expand Down

0 comments on commit b54eafb

Please sign in to comment.