Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserted emoji reformat input #55

Closed
kiliankoe opened this issue Apr 18, 2017 · 4 comments
Closed

Inserted emoji reformat input #55

kiliankoe opened this issue Apr 18, 2017 · 4 comments

Comments

@kiliankoe
Copy link

Sorry for the horrible issue title, not quite sure how to title this.

I wanted to include emojis in my description ('cause Apple engineers need some ❤️ and ✨ too). On inserting one with macOS' emoji picker something about my input changed. Typed spaces were much wider, text was monospaced. I've seen something similar happening in the commit text field in SourceTree, but nowhere else before. Not sure what that is, I'm not very familiar with NSTextFields and their API to have something particular in mind.

@keith
Copy link
Member

keith commented Apr 18, 2017

Thanks for reporting! I'll look in to this, I don't think I've typed emoji into brisk at all yet

@keith
Copy link
Member

keith commented Jun 18, 2017

Oh man, this was a fun one. It seems like AppKit is just totally failing here if you don't provide a font selection for the text view. If you do, the font doesn't change after typing an emoji.

I've fixed this here: #67

FWIW when typing an emoji there are still spacing changes in the text view, but it seems like that's just an OS issue:

https://stackoverflow.com/questions/43656445/text-position-shifts-down-font-also-changes-when-an-emoji-is-added-in-nstextvi
https://stackoverflow.com/questions/39460470/how-to-insert-emoji-into-nstextview-without-shifting-the-line-down

@keith
Copy link
Member

keith commented Jun 18, 2017

This is fixed on master, I'll probably create a new release with it today.

Thanks for submitting this! Please let me know if you find any more issues!

@keith keith closed this as completed Jun 18, 2017
@kiliankoe
Copy link
Author

Awesome 🎉 Thanks so much for the fix and also the links and extra info, much appreciated 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants