Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple-mobile-web-app-capable needs to be yes #4

Open
cheshrkat opened this issue Sep 15, 2016 · 1 comment
Open

apple-mobile-web-app-capable needs to be yes #4

cheshrkat opened this issue Sep 15, 2016 · 1 comment

Comments

@cheshrkat
Copy link

On iOS 9 and 10, manup.js was injecting the value of the manifest file, eg. <meta name="apple-mobile-web-app-capable" content="fullscreen">

However it must be 'yes', ie. <meta name="apple-mobile-web-app-capable" content="yes"> for iOS to respect it and other settings.

I had to remove manup.js to get fullscreen working on iOS as it overrides existing tags. So a generalised fix might be for manup to check for existing tags before injection; although that's slow. Otherwise there needs to be a catch to translate the iOS values from manifest values to yes.

@boyofgreen
Copy link
Owner

I think the latter will work (without much cost to perf). I'm planning do some clean up here soon, I'll make sure I fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants