Skip to content

Commit e86c04f

Browse files
authored
Make OIDC clientId uneditable (#992)
* Move oidcClientId to bottom card and make it readOnly * onChange not required for readonly field
1 parent 5cab913 commit e86c04f

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

src/sso/connections/EditConnection/oidc/index.lite.tsx

+11-13
Original file line numberDiff line numberDiff line change
@@ -297,19 +297,6 @@ export default function EditOIDCConnection(props: EditOIDCConnectionProps) {
297297
<Spacer y={6} />
298298
</Show>
299299
</Show>
300-
<InputField
301-
label='Client ID [OIDC Provider]'
302-
id='oidcClientId'
303-
required={true}
304-
classNames={state.classes.inputField}
305-
value={state.oidcConnection.oidcClientId || ''}
306-
handleInputChange={state.handleChange}
307-
aria-describedby='oidc-clientid-hint'
308-
/>
309-
<div id='oidc-clientid-hint' class={defaultClasses.hint}>
310-
ClientId of the app created on the OIDC Provider.
311-
</div>
312-
<Spacer y={6} />
313300
<SecretInputFormControl
314301
classNames={{ input: props.classNames?.secretInput }}
315302
label='Client Secret [OIDC Provider]'
@@ -463,7 +450,18 @@ export default function EditOIDCConnection(props: EditOIDCConnectionProps) {
463450
copyDoneCallback={props.successCallback}
464451
handleChange={state.handleChange}
465452
/>
453+
<Spacer y={6} />
454+
<InputField
455+
label='Client ID [OIDC Provider]'
456+
id='oidcClientId'
457+
required={true}
458+
readOnly
459+
classNames={state.classes.inputField}
460+
value={state.oidcConnection.oidcClientId || ''}
461+
aria-describedby='oidc-clientid-hint'
462+
/>
466463
</div>
464+
<Spacer y={6} />
467465
</Card>
468466
</Show>
469467
<Spacer y={4} />

0 commit comments

Comments
 (0)