Skip to content
This repository has been archived by the owner on May 22, 2018. It is now read-only.

puppet-popcorntime #657

Closed
josanastrid opened this issue Aug 26, 2014 · 7 comments
Closed

puppet-popcorntime #657

josanastrid opened this issue Aug 26, 2014 · 7 comments
Labels

Comments

@josanastrid
Copy link

puppet-popcorntime installs Popcorn-Time

https://github.com/josanastrid/puppet-popcorntime

@josanastrid
Copy link
Author

Please add. Thanks! :)

@tarebyte
Copy link
Member

Hi @josanastrid thanks for the new module! Would you mind parameterizing the version on the init.pp file

In your file it would look something like

# Install Popcorn-Time from popcorntime.io
class popcorntime($version = '0.3.2') {
  package{ 'Popcorn-Time':
    provider => 'appdmg_eula',
    source   => "https://cdn.popcorntime.io/build/Popcorn-Time-${version}-Mac.dmg"
  }
}

Thanks!

@josanastrid
Copy link
Author

Hi @tarebyte made the changes already. Thank you for the suggestion. :)

@radeksimko
Copy link
Contributor

FYI: Homebrew/homebrew-cask#3954 (comment)

Popcorn Time was subject to DMCA takedowns when hosted on GitHub

@seanknox
Copy link
Contributor

@tarebyte @josanastrid can this be merged in or the issue closed?

@tarebyte
Copy link
Member

I think @radeksimko has a good point. If it was subject to a DCMA takedown I'd rather not add it in.

@johnbellone I apologize for taking so long with this issue.

@seanknox
Copy link
Contributor

I think the DMCA concerns here are valid. I fear Boxen would simply receive a request to remove it as well. @josanastrid thanks for your work on this, sorry we can't merge it in!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

4 participants