feat: Support Sign Templates and new Sign Request statuses #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwwoda
reviewed
Sep 6, 2023
Box.V2.Test/Fixtures/BoxSignTemplate/GetAllSignTemplates200.json
Outdated
Show resolved
Hide resolved
| /// By default, we do not apply any expiration date on signature requests, and the signature request does not expire. | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = FieldDaysValid)] | ||
| public virtual int? DaysValid { get; private set; } |
There was a problem hiding this comment.
Is there a reason this property is set as nullable and all other value types (bools) are non-nullable?
mwwoda
reviewed
Sep 6, 2023
| /// The x coordinate of the input field. | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = FieldX)] | ||
| public virtual float X { get; private set; } |
| /// The height of the input field. | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = FieldHeight)] | ||
| public virtual float Height { get; private set; } |
mwwoda
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: SDK-3261
Closes: #916