Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: return proper object type from GetFileVersionsUnderRetentionForAssignmentAsync method #875

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

mwwoda
Copy link
Contributor

@mwwoda mwwoda commented Dec 14, 2022

No description provided.

Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only consider adding some IT tests for getting files under retention.

@mwwoda
Copy link
Contributor Author

mwwoda commented Dec 14, 2022

I would only consider adding some IT tests for getting files under retention.

Setting up the account to work with this endpoint was a hassle, so we will skip the integration test for this endpoint for now.

@mwwoda mwwoda merged commit 8b69de1 into version-5 Dec 14, 2022
@mwwoda mwwoda deleted the sdk-1915-file-version-retention-box-file branch December 14, 2022 12:39
mwwoda added a commit that referenced this pull request Jan 12, 2023
…move `use_index` references, return proper object from `GetFileVersionsUnderRetentionForAssignmentAsync` (#881)

* feat!: upgrade .net framework to 4.6.2 (#863)

* feat!: remove method with `use_index` reference (#870)

* feat!: remove deprecated methods (#874)

* fix!: return proper object type from `GetFileVersionsUnderRetentionForAssignmentAsync` method (#875)

* chore: ignore `bug fixes` in `readme` during linting (#876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants