Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing configureAwait(false) when awaiting to prevent deadlocks #775

Merged
merged 4 commits into from
Nov 23, 2021
Merged

fix: add missing configureAwait(false) when awaiting to prevent deadlocks #775

merged 4 commits into from
Nov 23, 2021

Conversation

mwwoda
Copy link
Contributor

@mwwoda mwwoda commented Nov 23, 2021

Resolves #773.

antusus
antusus previously approved these changes Nov 23, 2021
View reviewed changes
@mwwoda mwwoda changed the title fix: add missing configure await false to AuthenticateAsync fix: add missing configureAwait(false) when awaiting to prevent deadlocks Nov 23, 2021
antusus
antusus approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we can catch that with check dotnet_diagnostic.CA2007.severity = warning

@mwwoda mwwoda merged commit b16267e into main Nov 23, 2021
@mwwoda mwwoda deleted the add-missing-configure-await-false branch November 23, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwwoda @antusus