Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefreshAccessTokenAsync(string accessToken) lacks 'await' operators and will run synchronously. #662

Closed
AlfredBr opened this issue May 8, 2020 · 1 comment

Comments

@AlfredBr
Copy link

AlfredBr commented May 8, 2020

Since line 72 in JWTAuthRepository.cs is:
public async Task<OAuthSession> RefreshAccessTokenAsync(string accessToken)

Shouldn't line 88 in JWTAuthRepository.cs read:
return await Task.FromResult(session);

Instead of:
return session;

@sujaygarlanka
Copy link
Contributor

@AlfredBr Thanks for the feedback. You are correct. We will look into this.

Also, we have been getting some reports around deadlock issues for JWTAuth. If you are facing this issue, I recommend looking here (#638) for a temporary solution. We are looking to release a fix for this in the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants