Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all async operations as tasks #387

Closed
ohadschn opened this issue Sep 13, 2017 · 1 comment
Closed

Expose all async operations as tasks #387

ohadschn opened this issue Sep 13, 2017 · 1 comment

Comments

@ohadschn
Copy link
Contributor

I found a couple of places in the code that do async work yet don't expose a task (internally they do Task.Result):

IBoxResponse<OAuthSession> boxResponse = service.ToResponseAsync<OAuthSession>(boxRequest).Result;
(exposed externally)

IBoxResponse<OAuthSession> boxResponse = service.ToResponseAsync<OAuthSession>(boxRequest).Result;
(exposed externally and used by both AdminClient() and UserClient())

@coolboy
Copy link
Contributor

coolboy commented Sep 13, 2017

Thanks for your feedback, mark it into TODO list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants