Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix getReadStream delay reading #790

Merged
merged 5 commits into from
Jan 3, 2023
Merged

fix: Fix getReadStream delay reading #790

merged 5 commits into from
Jan 3, 2023

Conversation

congminh1254
Copy link
Member

@congminh1254 congminh1254 commented Jan 3, 2023 •
edited
Loading

Closes #763, closes #704, closes SDK-2645,

@congminh1254 congminh1254 marked this pull request as draft January 3, 2023 14:28
@coveralls
Copy link
Collaborator

coveralls commented Jan 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3831074747

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 96.274%
Totals Coverage Status
Change from base Build 3750165585: -0.02%
Covered Lines: 2802
Relevant Lines: 2876
💛 - Coveralls

@congminh1254 congminh1254 marked this pull request as ready for review January 3, 2023 14:53
antusus
antusus previously approved these changes Jan 3, 2023
View reviewed changes
src/api-request-manager.ts Outdated Show resolved Hide resolved
tests/integration_test/__tests__/file.test.js Outdated Show resolved Hide resolved
antusus
antusus approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@antusus antusus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@congminh1254 congminh1254 merged commit 6bfc1ee into main Jan 3, 2023
@congminh1254 congminh1254 deleted the sdk-2645 branch January 3, 2023 16:16
@huineng huineng mentioned this pull request Jan 12, 2023
Closed
@noseworthy noseworthy mentioned this pull request Feb 6, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antusus antusus antusus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@congminh1254 @coveralls @antusus