Skip to content

fix: Add fields query parameter to file and folder update #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

congminh1254
Copy link
Member

Part of SDK-2713, we need to limit the response if we are updating the shared_link only.

@congminh1254 congminh1254 marked this pull request as draft November 8, 2022 10:05
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3418420017

  • -1 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 96.283%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/managers/folders.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 3345222838: -0.07%
Covered Lines: 2787
Relevant Lines: 2860

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Nov 8, 2022

Pull Request Test Coverage Report for Build 3427785999

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 96.285%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/managers/folders.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 3420079953: -0.07%
Covered Lines: 2788
Relevant Lines: 2862

💛 - Coveralls

@congminh1254 congminh1254 changed the title feat: Limit response fields when create shared links fix: Add fields query params to file and folder update Nov 8, 2022
@congminh1254 congminh1254 changed the title fix: Add fields query params to file and folder update fix: Add fields query param to file and folder update Nov 8, 2022
@congminh1254 congminh1254 changed the title fix: Add fields query param to file and folder update fix: Add fields query parameter to file and folder update Nov 8, 2022
@congminh1254 congminh1254 force-pushed the SDK-2713-add-type-and-id-fields branch from 1d70437 to 5b9c879 Compare November 9, 2022 11:31
@congminh1254 congminh1254 marked this pull request as ready for review November 9, 2022 11:32
@arjankowski arjankowski merged commit a327deb into main Nov 10, 2022
@arjankowski arjankowski deleted the SDK-2713-add-type-and-id-fields branch November 10, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants