Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Sequence Diagrams #304

Closed
8 tasks done
ebrarkiziloglu opened this issue Oct 15, 2024 · 10 comments
Closed
8 tasks done

Design Sequence Diagrams #304

ebrarkiziloglu opened this issue Oct 15, 2024 · 10 comments
Assignees
Labels
effort: moderate Expected to take some time. priority: high Issue needs to be closed in the next two days. status: need review Issue is in need of a review. type: planning Planning for the project.

Comments

@ebrarkiziloglu
Copy link
Contributor

ebrarkiziloglu commented Oct 15, 2024

Description

We will design the relevant sequence diagrams for our project.

Tasks

Estimated Time

Time estimation in minutes.

Deadline

Date(18/10/2024) - 20.00

Reviewer

@set120120 - Deadline of the review(19/10/2024 - 23.59)

@ebrarkiziloglu
Copy link
Contributor Author

The wiki page is initiated.

@set120120
Copy link
Contributor

set120120 commented Oct 18, 2024

I think in the 3rd diagram on the wiki page (Edit Quiz), only insertion is mentioned, however both deletion and replacement should be added there. What do you think? @odenizddd

@set120120
Copy link
Contributor

set120120 commented Oct 18, 2024

image
In this photo (SS from 5th diagram), the post screen is clicked, the viewPost request is sent, but the comment section is passed without any response. Can you explain this @ebrarkiziloglu ? I think the comment section should be passed after the post screen response is received. The rest of this diagram is very good.

@set120120
Copy link
Contributor

set120120 commented Oct 18, 2024

2nd and 6th diagrams are so cool! @fahreddinozcan Good work 👏 🔥

@ebrarkiziloglu
Copy link
Contributor Author

In this photo (SS from 5th diagram), the post screen is clicked, the viewPost request is sent, but the comment section is passed without any response. Can you explain this @ebrarkiziloglu ? I think the comment section should be passed after the post screen response is received. The rest of this diagram is very good.

You're right, the post should be displayed before the user attempts to comment. Can you check the diagram again @set120120 ?

@ebrarkiziloglu
Copy link
Contributor Author

Also, we had agreed on using the term 'Reply' instead of commenting, so I also fixed that for the diagram 5.

@set120120
Copy link
Contributor

Now, they are okay. Good work @ebrarkiziloglu

@set120120
Copy link
Contributor

set120120 commented Oct 19, 2024

I am waiting for the last 2 diagrams to close the issue.

@ebrarkiziloglu
Copy link
Contributor Author

The issue is now ready for review @set120120.

@ebrarkiziloglu ebrarkiziloglu added status: need review Issue is in need of a review. priority: high Issue needs to be closed in the next two days. effort: moderate Expected to take some time. and removed status: new Issue is new. labels Oct 19, 2024
@set120120
Copy link
Contributor

Everything is okay. Thanks for your effort. @ebrarkiziloglu @odenizddd @HutkuC @fahreddinozcan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: moderate Expected to take some time. priority: high Issue needs to be closed in the next two days. status: need review Issue is in need of a review. type: planning Planning for the project.
Projects
None yet
Development

No branches or pull requests

5 participants