Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Sequence Diagram for Approving Article #53

Closed
mehmetemreakbulut opened this issue Apr 5, 2022 · 6 comments
Closed

Creating a Sequence Diagram for Approving Article #53

mehmetemreakbulut opened this issue Apr 5, 2022 · 6 comments
Assignees
Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Type: Documentation Improvements or additions to documentation

Comments

@mehmetemreakbulut
Copy link
Contributor

Description:

Creating a Sequence Diagram of a use case for approving an article in the application. This search can be performed according to many criteria such as the article's tags, category, author and date.

Reviewer: @palahb

Task Deadline: 06.04.2022 12.00

Review Deadline: 06.04.2022 15.00

@mehmetemreakbulut mehmetemreakbulut added Type: Documentation Improvements or additions to documentation Prio: Medium Importance of Issue: Medium Status: In Progress Issue is worked on, currently labels Apr 5, 2022
@canberkboun9
Copy link
Contributor

I moved some arrows to depict the chronological sequnce of events.

@mehmetemreakbulut
Copy link
Contributor Author

I think the final version of the diagram considering the suggestions in the meeting is appropriate. We can take action after review.

@palahb
Copy link
Contributor

palahb commented Apr 14, 2022

The sequence diagram seems good, but I have some suggestions:

  • I think places of the alternatives need to be revised. I think it is redundant and somehow seems a bit odd to have 2 alternatives that says the same thing. The inner alternative is enough and also the correct one I think. Outer one is a bit weird.
  • Also, status variable may not be necessary as it is suggested by the customer in the customer meeting 4.

@canberkboun9
Copy link
Contributor

  • Outer alternative is redundant because we should not assume that creating and object will be unsuccessful.
  • Status needs to be changed as we talked in Meeting 6.3 and Customer Meeting 4.

@canberkboun9
Copy link
Contributor

The changes were made.

@mehmetemreakbulut
Copy link
Contributor Author

mehmetemreakbulut commented Apr 15, 2022

Everything looks fine. I am closing the issue.

@mehmetemreakbulut mehmetemreakbulut added Status: Accepted Issue is reviewed, accepted and removed Status: In Progress Issue is worked on, currently labels Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants