Problem with function get_latitude_or_longitude

[cmarmonier]

I'm no sure but I think there is a problem with function get_latitude_or_longitude() in file epan/dissectors/packet-lldp.c.

	...
	/* Calculate decimal portion (using 25 bits for fraction) */
	tempValue = (tempValue & G_GINT64_CONSTANT(0x0000000001FFFFFF))/33554432;
	...
	return wmem_strdup_printf(wmem_packet_scope(), "%u.%04" G_GINT64_MODIFIER "u degrees %s",
	    integerPortion, tempValue, direction);

Type of tempValue is guint64... maximum value of tempValue is 0x1FFFFFF... 0x1FFFFFF / 33554432 = 0 => I think that floating-point numbers should always be ".0000" with printf.

Can you confirm ?

[vedangipatil117]

You might revise function as
/* Calculate decimal portion (using 25 bits for fraction) */
tempValue = (tempValue & G_GINT64_CONSTANT(0x0000000001FFFFFF));
tempValue = (tempValue * 10000) / 33554432; // Scale to 4 decimal places

return wmem_strdup_printf(wmem_packet_scope(), "%u.%04" G_GINT64_MODIFIER "u degrees %s",
integerPortion, tempValue, direction);