From 02cf4e11cef84939438aaee2a784754258930be7 Mon Sep 17 00:00:00 2001
From: Zac Mrowicki <mrowicki@amazon.com>
Date: Tue, 7 Jun 2022 16:08:10 +0000
Subject: [PATCH] Makefile: Add targets to create and validate Boot
 Configuration

This change adds two new targets to the Makefile.  Both make use of the
`bootconfig` tool in the latest version of the SDK.  The first new
target, `boot-config`, gives users the ability to create a properly
formatted Boot Configuration initrd given a valid config file.  The
second new target `validate-boot-config`, validates the Boot
Configuration initrd, listing its contents.  If the initrd is somehow in
a bad format, the tool will fail and print an error.

The Makefile targets expect a valid configuration file in the root of
the Bottlerocket repo named "bootconfig-input".  The Boot Configuration
initrd will be created in the root of the repo with the name
"bootconfig.data", which is what Bottlerocket expects the file to be
named when using it.
---
 Makefile.toml | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/Makefile.toml b/Makefile.toml
index b90bfda4ff5..e880f081de2 100644
--- a/Makefile.toml
+++ b/Makefile.toml
@@ -159,6 +159,11 @@ BUILDSYS_OVF_TEMPLATE = "${BUILDSYS_ROOT_DIR}/variants/${BUILDSYS_VARIANT}/templ
 # The default name of uploaded OVAs; override by setting VMWARE_VM_NAME
 VMWARE_VM_NAME_DEFAULT = "${BUILDSYS_NAME}-${BUILDSYS_VARIANT}-${BUILDSYS_ARCH}-v${BUILDSYS_VERSION_IMAGE}-${BUILDSYS_VERSION_BUILD}"
 
+# Config file for Boot Configuration initrd generation
+BOOT_CONFIG_INPUT = "${BUILDSYS_ROOT_DIR}/bootconfig-input"
+# Boot Configuration initrd
+BOOT_CONFIG = "${BUILDSYS_ROOT_DIR}/bootconfig.data"
+
 [tasks.setup]
 script = [
 '''
@@ -428,6 +433,61 @@ fi
 '''
 ]
 
+[tasks.boot-config]
+dependencies = ["fetch-sdk"]
+script_runner = "bash"
+script = [
+'''
+set -euo pipefail
+
+if [ ! -s "${BOOT_CONFIG_INPUT}" ]; then
+   echo "No boot configuration file exists, please create one at ${BOOT_CONFIG_INPUT}"
+   exit 1
+fi
+
+# If a Boot Config initrd already exists update it, otherwise create a new one
+boot_config_tmp=""
+boot_config=""
+if [ -s "${BOOT_CONFIG}" ]; then
+   echo "Boot config exists at '${BOOT_CONFIG}', updating it with input ${BOOT_CONFIG_INPUT}"
+   boot_config="${BOOT_CONFIG}"
+else
+   echo "Creating a new boot config from input ${BOOT_CONFIG_INPUT}"
+   boot_config_tmp=$(mktemp /tmp/bootconfig.data.XXXXX)
+   boot_config="${boot_config_tmp}"
+fi
+
+docker run --rm \
+   --network=none \
+   --user "$(id -u):$(id -g)" \
+   --security-opt label:disable \
+   -v "${BOOT_CONFIG_INPUT}":/tmp/bootconfig-input \
+   -v "${boot_config}":/tmp/bootconfig.data \
+   "${BUILDSYS_SDK_IMAGE}" \
+   bootconfig -a /tmp/bootconfig-input /tmp/bootconfig.data
+
+if [ -e "${boot_config_tmp}" ] ; then
+   mv "${boot_config_tmp}" "${BOOT_CONFIG}"
+fi
+echo "Boot configuration initrd may be found at ${BOOT_CONFIG}"
+'''
+]
+
+[tasks.validate-boot-config]
+dependencies = ["fetch-sdk"]
+script_runner = "bash"
+script = [
+'''
+docker run --rm \
+   --network=none \
+   --user "$(id -u):$(id -g)" \
+   --security-opt label:disable \
+   -v "${BOOT_CONFIG}":/tmp/bootconfig.data \
+   "${BUILDSYS_SDK_IMAGE}" \
+   bootconfig -l /tmp/bootconfig.data
+'''
+]
+
 # Builds a package including its build-time and runtime dependency packages.
 [tasks.build-package]
 dependencies = ["check-cargo-version", "build-tools", "publish-setup", "fetch-licenses"]