Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold the datastore version into the Thar image version #553

Closed
sam-aws opened this issue Nov 21, 2019 · 1 comment
Closed

Fold the datastore version into the Thar image version #553

sam-aws opened this issue Nov 21, 2019 · 1 comment
Assignees

Comments

@sam-aws
Copy link
Contributor

sam-aws commented Nov 21, 2019

Since a datastore version update always corresponds to a Thar image update, and a single Thar version is unlikely (or never going) to have multiple associated datastore versions, things could be simplified by getting rid of the datastore version entirely.

This would have a number of knock-on effects:

  • updater/* tools need to change to use the Thar version for migrations
  • update_metadata needs to be updated to remove mappings
  • migrations / migration install handling needs to update its versioning scheme
  • API tools need to update to use the Thar version where applicable
  • a transition period is required where tools and manifest.json support both schemes, before a point in time where any older image versions are deprecated and upgrading from them is not possible.
@sam-aws sam-aws added this to the Public Preview milestone Nov 21, 2019
@sam-aws sam-aws self-assigned this Nov 21, 2019
@zmrow zmrow removed this from the Public Preview milestone Jan 22, 2020
@iliana
Copy link
Contributor

iliana commented Feb 26, 2020

Fixed in #760.

@iliana iliana closed this as completed Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants