Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOTB: Remove conditional compilation and model dependency from static-pods #3619

Closed
2 tasks
Tracked by #3615
zmrow opened this issue Nov 29, 2023 · 0 comments · Fixed by #3891
Closed
2 tasks
Tracked by #3615

OOTB: Remove conditional compilation and model dependency from static-pods #3619

zmrow opened this issue Nov 29, 2023 · 0 comments · Fixed by #3891
Assignees
@jmt-lab
Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo
Milestone
no-conditional-co...

Comments

@zmrow
Copy link
Contributor

zmrow commented Nov 29, 2023

Currently the program is conditionally compiled based on the container orchestrator. It also makes calls to the API and pulls the entire set of settings from the model - which will need to change for OOTB.

  • Remove the conditional compilation directives and exclude the package from variants not running k8s
  • Remove the model dependency (probably read from a file rendered by schnauzer)
@zmrow zmrow added this to the no-conditional-compilation milestone Nov 29, 2023
@jmt-lab jmt-lab assigned jmt-lab and unassigned jmt-lab Feb 15, 2024
@webern webern added the area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo label Feb 29, 2024
@sam-berning sam-berning mentioned this issue Mar 21, 2024
Closed
9 tasks
@jmt-lab jmt-lab mentioned this issue Apr 11, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmt-lab jmt-lab

Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo
Projects
None yet
Milestone
no-conditional-compilation
Development

Successfully merging a pull request may close this issue.

static-pods: remove conditional compilation jmt-lab/bottlerocket
3 participants
@zmrow @webern @jmt-lab