Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netdog] Improve error messaging in netdog when failing to match type of network device #2657

Open
yeazelm opened this issue Dec 13, 2022 · 0 comments
Labels
area/metal Bare metal support type/enhancement New feature or request

Comments

@yeazelm
Copy link
Contributor

yeazelm commented Dec 13, 2022

There is a known issue in serde where matching enums obscures the errors when failing to match, making the user-facing errors opaque. Its been around for a while and folks have tried their own ways of solving this.

Since we have lots of exposure to this issue, we should figure out a way to expose the Deserialization failures to end users in a better way so they can debug why their net.toml isn't parsing into proper configuration. The primary goal is to provide the lower-level errors to the user so they can piece together why their config didn't result in proper configuration. Pulling this in will allow us to move all validation into Deserialize implementations and remove the Validate trait since our error messages won't be masked by the top-level enum deserialize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metal Bare metal support type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant