Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionalize shibaken to not build for non-AWS variants #1590

Closed
jpculp opened this issue May 20, 2021 · 0 comments
Closed

Conditionalize shibaken to not build for non-AWS variants #1590

jpculp opened this issue May 20, 2021 · 0 comments
Assignees
@jpculp
Labels
type/enhancement New feature or request
Milestone
v1.1.2

Comments

@jpculp
Copy link
Member

jpculp commented May 20, 2021

We should conditionalize shibaken in os.spec, like we do for pluto, since we don't want to run it on non-AWS platforms.

Originally posted by @bcressey in #1372 (comment)
@jpculp jpculp self-assigned this May 20, 2021
@jpculp jpculp added type/enhancement New feature or request priority/p1 labels May 20, 2021
@jpculp jpculp added this to the next milestone May 20, 2021
This was referenced May 20, 2021
Merged
Merged
@jpculp jpculp added status/in-progress This issue is currently being worked on and removed status/notstarted status/in-progress This issue is currently being worked on labels May 21, 2021
@jpculp jpculp closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpculp jpculp

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
v1.1.2
Development

No branches or pull requests
1 participant
@jpculp