Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support image registry mirrors/pull-through caches #1577

Closed
etungsten opened this issue May 14, 2021 · 0 comments · Fixed by #1629
Closed

Support image registry mirrors/pull-through caches #1577

etungsten opened this issue May 14, 2021 · 0 comments · Fixed by #1629
Assignees
Labels
area/ecs ECS area/kubernetes K8s including EKS, EKS-A, and including VMW type/enhancement New feature or request
Milestone

Comments

@etungsten
Copy link
Contributor

etungsten commented May 14, 2021

What I'd like:
A way to configure image pull-through caches/registry mirrors for the container runtimes.

A generic setting of the following form would probably work:

[settings.image-registry.mirrors]
"docker.io" = ["my-own-docker-registry-cache", "some-other-docker-registry", "official-docker-registry"]
...

Note that docker only supports mirroring/caching with DockerHub. So we might need to special case the template for daemon.json like so:

{{~#if settings.image-registry.mirrors."docker.io"}}
"registry-mirrors": [{{join_array ", " settings.image-registry.mirrors."docker.io"}}]
{{~/if}}

For cri-containerd, we'd configure it here.

Any alternatives you've considered:
None

@etungsten etungsten added area/kubernetes K8s including EKS, EKS-A, and including VMW area/ecs ECS status/needs-triage Pending triage or re-evaluation type/enhancement New feature or request labels May 14, 2021
@jhaynes jhaynes added this to the next+1 milestone Jun 14, 2021
@etungsten etungsten self-assigned this Jun 22, 2021
@etungsten etungsten added status/needs-proposal Needs a more detailed proposal for next steps and removed status/needs-triage Pending triage or re-evaluation labels Jun 22, 2021
@etungsten etungsten added status/in-progress This issue is currently being worked on and removed status/needs-proposal Needs a more detailed proposal for next steps labels Jun 23, 2021
@bcressey bcressey removed the status/in-progress This issue is currently being worked on label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ecs ECS area/kubernetes K8s including EKS, EKS-A, and including VMW type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants