Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updog: upgrade signal-hook #1268

Closed
webern opened this issue Jan 8, 2021 · 0 comments · Fixed by #1328
Closed

updog: upgrade signal-hook #1268

webern opened this issue Jan 8, 2021 · 0 comments · Fixed by #1328
Assignees
Labels
type/bug Something isn't working

Comments

@webern
Copy link
Contributor

webern commented Jan 8, 2021

Signal hook is at signal-hook = "0.1.13", but the current version is 0.3. When I tried the upgrade some breaking change occurred which I think is out-of-scope for the more mechanical version bumps that I am currently applying.

Specifically:

error[E0599]: no method named `cloned` found for struct `signal_hook::iterator::SignalsInfo` in the current scope
   --> updater/updog/src/main.rs:449:30
    |
449 |     let signals_bg = signals.cloned();
    |                              ^^^^^^ method not found in `signal_hook::iterator::SignalsInfo`

This should probably be tackled in isolation to ensure nothing about the API breaks.

@jhaynes jhaynes added status/needs-triage Pending triage or re-evaluation type/bug Something isn't working labels Jan 13, 2021
@gregdek gregdek added priority/p0 and removed status/needs-triage Pending triage or re-evaluation labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants