Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arg/env in userdata for host-containers #1250

Open
ellistarn opened this issue Dec 17, 2020 · 5 comments
Open

Allow arg/env in userdata for host-containers #1250

ellistarn opened this issue Dec 17, 2020 · 5 comments
Labels
area/core Issues core to the OS (variant independent) status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request

Comments

@ellistarn
Copy link
Contributor

What I'd like:
I'd like to be able to more easily parameterize env and args when running containers (similar to how I might w/ docker/k8s) using bottlerocket user data. I see there is a similar feature here: #1244, but IIUC, it doesn't quite go far enough to cover my use case.

[settings.host-containers.my-container]
enabled = true
env.MY_ENV_VAR = "my env var's value"
args = ["list", "of", "strings"]

Any alternatives you've considered:
I might be able to do this with just

[settings.host-containers.admin]
enabled = true
user-data = "aGkgdGhlcmUKaG93IGFyZSB5b3UK"

but this is beyond my current knowledge of bottlerocket.

@samuelkarp samuelkarp added the status/needs-triage Pending triage or re-evaluation label Dec 17, 2020
@jhaynes jhaynes added priority/p1 type/enhancement New feature or request and removed status/needs-triage Pending triage or re-evaluation labels Dec 21, 2020
@ellistarn
Copy link
Contributor Author

Any word here?

@tjkirch
Copy link
Contributor

tjkirch commented Jan 8, 2021

Any word here?

Thanks for the idea - it would definitely be nice for users, and we plan to work on it, but haven't started yet.

@ellistarn
Copy link
Contributor Author

This might be somewhat heretical, but it would be amazing in my eyes if this supported a variant of the YAML representation of https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#podspec-v1-core. Perhaps a subset, like env, arg, cmd.

@ellistarn
Copy link
Contributor Author

This would make bottlerocket an extremely attractive OS for running Kubernetes control planes.

@gregdek gregdek added this to the backlog milestone Apr 1, 2021
@gabegorelick
Copy link

This is really needed for bootstrap containers. Currently, it seems like you have to build custom images to do anything useful. Even with user-data support, I'm not aware of any public images that handle user-data at /.bottlerocket/host-containers/current/user-data. So you have to end up having to build a generic host image that execs whatever's in /.bottlerocket/host-containers/current/user-data (assuming your user data is a script).

Supporting custom cmd/args would mean avoiding having to maintain that base image since you can just bash /.bottlerocket/host-containers/current/user-data from whatever image you like.

@tjkirch tjkirch removed their assignment Dec 11, 2021
@stmcginnis stmcginnis added status/needs-triage Pending triage or re-evaluation and removed priority/p1 labels Dec 1, 2022
@stmcginnis stmcginnis added area/core Issues core to the OS (variant independent) status/icebox Things we think would be nice but are not prioritized and removed status/needs-triage Pending triage or re-evaluation labels Feb 16, 2023
@stmcginnis stmcginnis removed this from the backlog milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues core to the OS (variant independent) status/icebox Things we think would be nice but are not prioritized type/enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

7 participants