Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsys: template AMI names #1093

Closed
tjkirch opened this issue Aug 30, 2020 · 1 comment
Closed

pubsys: template AMI names #1093

tjkirch opened this issue Aug 30, 2020 · 1 comment
Labels
status/needs-triage Pending triage or re-evaluation type/enhancement New feature or request
Milestone

Comments

@tjkirch
Copy link
Contributor

tjkirch commented Aug 30, 2020

Per #1091, it would be nice if users could specify in Infra.toml a template of desired AMI names.

Currently there's a template baked into Makefile.toml called PUBLISH_AMI_NAME_DEFAULT that users can override using cargo make ami -e PUBLISH_AMI_NAME=foo (with #1091), but if you have a consistent naming pattern, keeping a template in Infra.toml is simpler.

@gregdek gregdek added status/notstarted type/enhancement New feature or request labels Apr 2, 2021
@gregdek gregdek added this to the backlog milestone Apr 2, 2021
@stmcginnis stmcginnis added status/needs-triage Pending triage or re-evaluation and removed priority/p2 labels Dec 1, 2022
@stmcginnis
Copy link
Contributor

We may need something like this for out of tree builds, but that effort will address that if/when needed. Since we don't need a separate issue specifically for that part of it, going to close this as not something we've found we've strongly needed otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/needs-triage Pending triage or re-evaluation type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants