Skip to content

Commit 047cf82

Browse files
committed
Fix Xcode project settings warnings
Pulled these changes from the RN upstream commit: facebook/react-native@c298e0a#diff-065bc63a1a0283f31962d4ab2316087b We already have enabled some of the settings thus producing less changes than in RN's commit. Warnings fixed: https://user-images.githubusercontent.com/5353594/41173274-1a4fbb3e-6b0b-11e8-973b-8290794a4f8b.png Enabled for both 'Debug' and 'Release' builds. Upgraded Project settings to be compatible with Xcode 9.4 This change introduced in the Starting project template here: facebook/react-native@c298e0a#diff-065bc63a1a0283f31962d4ab2316087b
1 parent 2ed5f7a commit 047cf82

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

ios/ZulipMobile.xcodeproj/project.pbxproj

+17-1
Original file line numberDiff line numberDiff line change
@@ -1017,7 +1017,7 @@
10171017
83CBB9F71A601CBA00E9B192 /* Project object */ = {
10181018
isa = PBXProject;
10191019
attributes = {
1020-
LastUpgradeCheck = 810;
1020+
LastUpgradeCheck = 0940;
10211021
ORGANIZATIONNAME = Facebook;
10221022
TargetAttributes = {
10231023
00E356ED1AD99517003FC87E = {
@@ -1880,14 +1880,22 @@
18801880
CLANG_CXX_LIBRARY = "libc++";
18811881
CLANG_ENABLE_MODULES = YES;
18821882
CLANG_ENABLE_OBJC_ARC = YES;
1883+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
18831884
CLANG_WARN_BOOL_CONVERSION = YES;
1885+
CLANG_WARN_COMMA = YES;
18841886
CLANG_WARN_CONSTANT_CONVERSION = YES;
1887+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
18851888
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
18861889
CLANG_WARN_EMPTY_BODY = YES;
18871890
CLANG_WARN_ENUM_CONVERSION = YES;
18881891
CLANG_WARN_INFINITE_RECURSION = YES;
18891892
CLANG_WARN_INT_CONVERSION = YES;
1893+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
1894+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1895+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
18901896
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
1897+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
1898+
CLANG_WARN_STRICT_PROTOTYPES = YES;
18911899
CLANG_WARN_SUSPICIOUS_MOVE = YES;
18921900
CLANG_WARN_UNREACHABLE_CODE = YES;
18931901
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1933,14 +1941,22 @@
19331941
CLANG_CXX_LIBRARY = "libc++";
19341942
CLANG_ENABLE_MODULES = YES;
19351943
CLANG_ENABLE_OBJC_ARC = YES;
1944+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
19361945
CLANG_WARN_BOOL_CONVERSION = YES;
1946+
CLANG_WARN_COMMA = YES;
19371947
CLANG_WARN_CONSTANT_CONVERSION = YES;
1948+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
19381949
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
19391950
CLANG_WARN_EMPTY_BODY = YES;
19401951
CLANG_WARN_ENUM_CONVERSION = YES;
19411952
CLANG_WARN_INFINITE_RECURSION = YES;
19421953
CLANG_WARN_INT_CONVERSION = YES;
1954+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
1955+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
1956+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
19431957
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
1958+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
1959+
CLANG_WARN_STRICT_PROTOTYPES = YES;
19441960
CLANG_WARN_SUSPICIOUS_MOVE = YES;
19451961
CLANG_WARN_UNREACHABLE_CODE = YES;
19461962
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

ios/ZulipMobile.xcodeproj/xcshareddata/xcschemes/ZulipMobile.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0810"
3+
LastUpgradeVersion = "0940"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "NO"

0 commit comments

Comments
 (0)