Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Version #7

Open
ghaith opened this issue Nov 4, 2015 · 5 comments
Open

Java Version #7

ghaith opened this issue Nov 4, 2015 · 5 comments

Comments

@ghaith
Copy link

ghaith commented Nov 4, 2015

Should we keep compatibility with older java versions? Currently all manifests have a java 6 dependency. Should we limit the fixes to java 6 compatibility, or would you think it's ok to move to Java 8. The move will also mean a lot of the xtend commited code can be changed to Java 8 as well

Tagging @mrieder if he has input as well

@borisbrodski
Copy link
Owner

Hello Ghaith,

we will have to move to the Java 8 at some point in the future.
Why do you think it's important right now?

When we complete the next release (using Xtext 2.9), Jnario will
be able to generate Java 8 code anyway.

Currently IMHO though we should make sure that Jnario survives.
Bringing up the next release is essential.

I will add "Migrate to Java 8" to the TODO list here: sebastianbenz#160

Cheers,
Boris

@borisbrodski
Copy link
Owner

I think we should stick to the Xtext at this one. When Xtext migrates to Java 8, we can safely do it as well.

@ghaith
Copy link
Author

ghaith commented Nov 4, 2015

Ok, in that case I'll restrict my environment / current fixes to a Java 6 compliant one.
I agree that a move to Java8 might take long, and is probably not necessary for this release.
The idea started as we were working on a fix and used a Java 8 class before noticing that we are still using Java 6

@riederm
Copy link

riederm commented Apr 2, 2017

I'm close to submitting a branch for xtext.2.11. Xtext2.11 requires java 1.8 so I moved all plugins to java.18

@borisbrodski
Copy link
Owner

Could you please check, if your commits are present in the current master branch?

I thought, Jnario is still on Java 1.6, since the ASM 5.0.x (required by PegDown) can't handle Java 8 stuff.
I replaced PegDown with FlexMark now, so we are free to move forward with the Java versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants