Added support for positioning in BayesNet plotting #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetongumich
approved these changes
Jan 27, 2022
|
|
||
| for (auto conditional : *this) { | ||
| for (auto conditional : boost::adaptors::reverse(*this)) { |
There was a problem hiding this comment.
Maybe a comment here why reversing the order? Like following a top-down order in printing?
There was a problem hiding this comment.
It is because Bayes nets are typically specified in reverse topological sort order, that's how they come out of elimination. Will add comments in the next PR to not restart CI for this one thing
| std::map<Key, Vector2> variablePositions; | ||
|
|
||
| /** | ||
| * The position hints allow one to use symbol character and index to specify |
There was a problem hiding this comment.
I like this functionality
There was a problem hiding this comment.
Do we want to specify factor positions as well?
There was a problem hiding this comment.
Yeah, forgot about that. will add. Currently in graphVizFormatting, actually, but I need it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variablePositionsin DotWriterBayesNetuse them, if givenSymbolicBayesNetandGaussianBayesNetfromBayesNetso they have this as wellThis supports graphs in the book that look like this: