Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Quick Mount #1435

Open
Justinzobel opened this issue Oct 16, 2022 · 6 comments · May be fixed by #1664
Open

FR: Quick Mount #1435

Justinzobel opened this issue Oct 16, 2022 · 6 comments · May be fixed by #1664
Labels
type:enhancement Improvement of an existing function

Comments

@Justinzobel
Copy link

The problem

The Mount option is good but requires the user to have already created an empty folder to mount to. This seems to be a little bit of extra work for the basic user.

Requested Solution

A Quick Browse button. This button would create a folder for the user, for example in /tmp or in a known Borg location e.g. ~/.borg and mount the selected Archive for the user. This way a user can quickly access the backup and browser for files. The button would then change to an Unmount button which would unmount the temporary directory and clean up.
@Justinzobel Justinzobel added the type:enhancement Improvement of an existing function label Oct 16, 2022
@real-yfprojects real-yfprojects changed the title FR: Quick Browse FR: Quick Mount Oct 16, 2022
@real-yfprojects
Copy link
Collaborator

Thanks for opening the FR. We were already had the idea for such a feature #1281.

I think this feature should include opening the folder in the file explorer automatically as well as a setting to disable this behaviour.

@diivi
Copy link
Contributor

diivi commented Mar 17, 2023

I have a few questions regarding this:

  1. what should be the directory where Vorta does a "Quick Mount" and open it later?
  2. Should quick mount be a new button or a setting, which when enabled, the user won't have to select a folder when pressing the mount button everytime.

@Justinzobel
Copy link
Author

  1. It should likely be mounted in the user's home as vorta backups are done by the user (in comparison to mounting in /tmp or /mnt as they are publicly accessible). Vorta could create a temporary directory in the user's home folder e.g. ~/Vorta-Restore-{randomcharacters} and mount it there.

  2. I think it should be a button, Vorta is a GUI application to make the backup and restore of user data as simple and easy as possible. Alternatively, the Mount button could default to a quick mount and a dropdown next to it could allow users to specify the location if they desire. For example like the GitHub button below the comment box:

image

@real-yfprojects
Copy link
Collaborator

I like the dropdown solution.

@diivi
Copy link
Contributor

diivi commented Mar 18, 2023

I like the dropdown solution.

Could you point me to the right direction (qt docs?), If I were to implement something like that?
I would also like a quick mount feature.

@jetchirag
Copy link
Contributor

@diivi I think you can use QMenu for UI

vorta/src/vorta/views/repo_tab.py

Lines 29 to 34 in 1f12782

self.menuAddRepo = QMenu(self.bAddRepo)
self.menuAddRepo.addAction(self.tr("New Repository…"), self.new_repo)
self.menuAddRepo.addAction(self.tr("Existing Repository…"), self.add_existing_repo)
self.bAddRepo.setMenu(self.menuAddRepo)

vorta/src/vorta/assets/UI/repotab.ui

Lines 144 to 151 in 1f12782

<widget class="QToolButton" name="bAddRepo">
<property name="text">
<string/>
</property>
<property name="popupMode">
<enum>QToolButton::InstantPopup</enum>
</property>
</widget>

@diivi diivi linked a pull request Mar 19, 2023 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement Improvement of an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: quick mount diivi/vorta
4 participants
@Justinzobel @jetchirag @diivi @real-yfprojects