-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better status message when adding existing repo #1306
Comments
Hi! The repo should be over the net right? because if I add a local, it fetches it instantly 🤔 |
Can I try to work on this after #1620 is merged ? |
👍 Have a look how this was implemented for other long running jobs. |
A slow internet connection or disk speed will extend the time needed. |
Hi! Actually I've a issue testing/reproducing it 😅
any recommendation on how can I reproduce this issue ? 😅 |
Try a slow usb stick or a remote repo with a slow internet connection. You can also try throttling disc speed for vorta. |
Hi! @real-yfprojects, I can reproduce the issue now, as per @m3nu 's suggestion we could show a status message, the status message will be in a form of popup ? because the status is already shown as |
I think that would qualify as blocking the ui since we currently show a popup too. |
Hm! So I assume that, this might be a threading problem 🤔 since it is a long task other inputs are getting registered but are not reflecting instantly resulting in I've also seen that the python's threading is used in |
Python's threading library is very well integrated and imo the better choice. Still we sometimes use QThread since it exposes a finished signals. AFAIK pyqt signals only work correctly when being called/instanciated from/in a QThread. There would be multiple possibilities for implemtikg this. You could do it similar to here: Or close the the add repo dialog and let init run as a normal borgjob like other commands do too. |
Hi! I've tried closing the dialog box and it still does not responds some times, I think the UI breaks because of the mouse clicks as it keeps listening to user inputs while it is completing a long job, but if we leave the process idle it would complete without any problem (I didn't try with the 10+ GB repos mentioned above since I'm using the trial version of borgbase). In my opinion disabling mouse clicks would work . I know this might look rude like you are disabling the mouse just to overcome the issue, but that might help Btw is there any way we could see the fetching percentage ? we could add a progress bar to show update the user about the progress instead of showing What do you think @real-yfprojects 😅 |
Try running
The issue should be that the borg job isn't run in a new thread, blocking the current thread. Therefore qt isn't able to process any GUI events. vorta/src/vorta/views/repo_add_dialog.py Lines 245 to 249 in 961e0b5
The variable is named incorrectly since a borg job doesn't create a thread. |
Works Now! but has a small bug, let me push the changes 😄 |
- Avoids Blocking UI When Adding Existing Repo Closes borgbase#1306
- Avoids freezing UI when an existing repo is added Closes borgbase#1306
- Avoids freezing UI when an existing repo is added Closes borgbase#1306
- Avoids freezing UI when an existing repo is added. Closes borgbase#1306
- Avoids freezing UI when an existing repo is added. Closes borgbase#1306
- Avoids freezing UI when an existing repo is added Closes borgbase#1306
- Avoids freezing UI when an existing repo is added Closes borgbase#1306
- Avoids freezing UI when an existing repo is added. Closes borgbase#1306
- Avoids freezing UI when an existing repo is added. Closes borgbase#1306
- Avoids freezing UI when an existing repo is added Closes borgbase#1306
- Avoids freezing UI when an existing repo is added Closes borgbase#1306
Describe the bug
With Borg 1.2, Borg will pull a good amount of data before adding the repo. Currently we don't show a proper status message and just block the UI.
Proposed solution is to avoid blocking the UI and show a meaningful status message.
To Reproduce
Steps to reproduce the behavior:
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: