Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make Helm chart values templating compatible with the Maven Build Cache #291

Open
1 task
ewilkins-csi opened this issue Aug 23, 2024 · 0 comments
Open
1 task
Labels
enhancement New feature or request

Comments

@ewilkins-csi
Copy link
Contributor

Description

For any Helm charts that use our own images, we currently inject the project version for the image tag at build time using Google's maven-replacer-plugin to process a file named values.template.yaml and output the result as values.yaml. This causes issues with the build cache for any charts which depend on that templated chart. E.g., aissemble-configuration-store-chart depends on aissemble-quarkus-chart. If there were no changes to the Quarkus chart and it's build is skipped, then there is no values.yaml produced. When the build for the Configuration Store starts, it looks at the path-based dependency for Quarkus and because there is no values.yaml, the linter fails.

We need to preserve the path-based dependency (which is replaced with the proper remote dependency automatically during the deploy phase of the helm-maven-plugin) so that when building locally, changes are properly propagated. One potential approach would be to mirror what's being done for the path-based dependencies in Chart.yaml and just process the values file at build time in the helm-maven-plugin. The would mirror what the Fabric8 docker-maven-plugin does as well.

DOD

aissemble-configuration-store-chart should build successfully when the aissemble-quarkus-chart has a build-cache hit, but the config store chart has a build-cache miss.

  • Using checkboxes helps to communicate progress

Test Strategy/Script

How will this feature be verified?

References/Additional Context

A clear and concise description of any alternative solutions or features you've considered.
Add any other context, links, or screenshots about the feature request here.

@ewilkins-csi ewilkins-csi added the enhancement New feature or request label Aug 23, 2024
@ewilkins-csi ewilkins-csi added this to the 1.9.0 milestone Aug 23, 2024
@ewilkins-csi ewilkins-csi modified the milestones: 1.9.0, 1.10.0 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant