You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For any Helm charts that use our own images, we currently inject the project version for the image tag at build time using Google's maven-replacer-plugin to process a file named values.template.yaml and output the result as values.yaml. This causes issues with the build cache for any charts which depend on that templated chart. E.g., aissemble-configuration-store-chart depends on aissemble-quarkus-chart. If there were no changes to the Quarkus chart and it's build is skipped, then there is no values.yaml produced. When the build for the Configuration Store starts, it looks at the path-based dependency for Quarkus and because there is no values.yaml, the linter fails.
We need to preserve the path-based dependency (which is replaced with the proper remote dependency automatically during the deploy phase of the helm-maven-plugin) so that when building locally, changes are properly propagated. One potential approach would be to mirror what's being done for the path-based dependencies in Chart.yaml and just process the values file at build time in the helm-maven-plugin. The would mirror what the Fabric8 docker-maven-plugin does as well.
DOD
aissemble-configuration-store-chart should build successfully when the aissemble-quarkus-chart has a build-cache hit, but the config store chart has a build-cache miss.
Using checkboxes helps to communicate progress
Test Strategy/Script
How will this feature be verified?
References/Additional Context
A clear and concise description of any alternative solutions or features you've considered.
Add any other context, links, or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Description
For any Helm charts that use our own images, we currently inject the project version for the image tag at build time using Google's
maven-replacer-plugin
to process a file namedvalues.template.yaml
and output the result asvalues.yaml
. This causes issues with the build cache for any charts which depend on that templated chart. E.g.,aissemble-configuration-store-chart
depends onaissemble-quarkus-chart
. If there were no changes to the Quarkus chart and it's build is skipped, then there is novalues.yaml
produced. When the build for the Configuration Store starts, it looks at the path-based dependency for Quarkus and because there is novalues.yaml
, the linter fails.We need to preserve the path-based dependency (which is replaced with the proper remote dependency automatically during the
deploy
phase of thehelm-maven-plugin
) so that when building locally, changes are properly propagated. One potential approach would be to mirror what's being done for the path-based dependencies inChart.yaml
and just process the values file at build time in thehelm-maven-plugin
. The would mirror what the Fabric8docker-maven-plugin
does as well.DOD
aissemble-configuration-store-chart
should build successfully when theaissemble-quarkus-chart
has a build-cache hit, but the config store chart has a build-cache miss.Test Strategy/Script
How will this feature be verified?
References/Additional Context
A clear and concise description of any alternative solutions or features you've considered.
Add any other context, links, or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: