Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs from preston #1

Open
schanzer opened this issue Aug 14, 2019 · 0 comments
Open

TODOs from preston #1

schanzer opened this issue Aug 14, 2019 · 0 comments

Comments

@schanzer
Copy link
Member

schanzer commented Aug 14, 2019

  • TODO figure out why down is showing up as Ctrl+Shift+I instead of down in pyret-blocks
    this is why not navigating as should be

  • TODO copy general testing over to pyret-blocks
    "General testing" makes sure that we always move to the next block and that we eventually
    finish going "down" over all of a node.
    Really, should do this once testing works in pyret-blocks

  • TODO make sure that cpo+cmb works with updated pyret-blocks
    X TODO merge pyret parser tests PR (Couldn't figure this out!)
    X use newer chrome and see if that works
    try removing pyret tests
    -> if this works, dig into it?
    Didn't work due to slowness issues?
    Chrome 73.0.3683 (Linux 0.0.0) The CodeMirrorBlocks Class when dealing with node activation, should cancel the editability of activated node when Alt-Q is pressed FAILED
    Error: Expected false to be true.
    at
    at UserContext. (webpack:///spec/activation-test.js:143:41 <- spec/index.js:73356:42)
    at
    at asyncGeneratorStep (spec/index.js:73217:103)

    split languages into own files now???

  • TODO typescript declaration file for CMB
    https://medium.com/@chris_72272/migrating-to-typescript-write-a-declaration-file-for-a-third-party-npm-module-b1f75808ed2
    -> not needed right now since seems to work okay without it, only gives warnings

  • TODO id error on deletion?
    sometimes when deleting a node an error message about id is raised

  • TODO update readme for wescheme-blocks and pyret-blocks

  • TODO add nodes in search bar

    • TODO rebase searchbar branch off of merged Pyret
      in primitives-config.js
      ERRORS:
      RESOLVED things are there, but can't even pick up nodes
      RESOLVED also not displayed as nodes in the bottom

    implement getASTNodeForPrimitive for Pyret (look at wescheme)
    -> droptarget throwing error of null sibling?
    happens by itself, so probably making incorrectly

    figure out difference between op and check-op
    -> different constructs in parse, so maybe different objects?
    and actually, using the same literal constructor! so maybe can merge tables or something? or use the same function

  • PUNT think about name is currently a string in check-block
    maybe another good place for a hole?
    revisit when have things besides blocks (like more template-y things)

  • TODO Vertical args?
    Basically just Args but vertical!

  • TODO review drop targets for pyret
    maybe add some, maybe remove the ones around function in fun-app

  • TODO add pyret comments to tests and make sure that everything still renders and works

  • TODO add documentation to functions in tests and make sure that everything still renders and works

  • provider/context for cmb
    don't need to do this since bundling pyret and cmb together,
    but would if wanted to split them out

  • now that we know that ctrl-enter exists, do we want to revert bind?
    Bind is sometimes rendered as a literal with the name and annotation concatenated

  • PUNT Documentation on making keyboard navigable nodes?
    Just make sure everything is a Node?
    -> has issues for Bind
    and when using string instead of reactElement for checktest
    has popped up when rendering s-paren just as the node inside of it

  • different notation for functions with no args?

  • Look into localization patterns in SE
    and see if it matches what I suggested

  • similar fromTextArea thing for CMB

  • if run into unmounted rendering, replicate and send to E and J

  • duplicates f for g (for f(x), g(y))
    check to see if order of statements (in sequence?) is also reversed
    not inside sequence, check inside program
    inconsistent orderings passed for f(x) and g(y) program
    is this just due to other tree error?
    looks like we reverse in loop in unify, so seems likely
    dig around ast and double-check source locs
    check where cursor is when click to the right of function definition

  • Add CM to CMB's prototype chain?
    see if this is a problem... weird since hasn't come up yet

  • talk to E about fromTextArea for repl
    -> where is repl created?
    -> wait on this since repl is normal for now

  • things in https://docs.google.com/spreadsheets/d/1BlY3aamP7JzuSrqzrVfyxYPggyhRkfKfDVYUPzHt100/edit#gid=0

  • Explore more why adding in pyret tests made things so brittle
    removing pyret nav tests made 5000 work again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant