Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a root node does not update focus correctly #592

Closed
schanzer opened this issue Nov 17, 2021 · 0 comments · Fixed by #593
Closed

Deleting a root node does not update focus correctly #592

schanzer opened this issue Nov 17, 2021 · 0 comments · Fixed by #593
Assignees
@pcardune
Labels
bug
Milestone
alpha

Comments

@schanzer
Copy link
Member

schanzer commented Nov 17, 2021 •
edited
Loading

Describe the bug
If root n is activated, then selected and deleted, activation should shift to root n-1

To Reproduce
Steps to reproduce the behavior:

  1. Go to the default editor, and switch to block mode
  2. Click on the (+ 1 2) expression, then the space bar to select it
  3. "delete" or "cut"

Expected behavior
(print "hello word") is activated

Desktop (please complete the following information):

  • OS: OS X Catalina
  • Browser Brave
  • Version 1.31 (Chromium 95)

This would make a good test case for #468
@schanzer schanzer added the bug label Nov 17, 2021
@schanzer schanzer added this to the alpha milestone Nov 17, 2021
@pcardune pcardune mentioned this issue Nov 17, 2021
Merged
@pcardune pcardune linked a pull request Nov 17, 2021 that will close this issue
Focus the currently focused node when it mounts #593
Merged
@pcardune pcardune self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcardune pcardune

Labels
bug
Projects
None yet
Milestone
alpha
Development

Successfully merging a pull request may close this issue.

Focus the currently focused node when it mounts bootstrapworld/codemirror-blocks
2 participants
@schanzer @pcardune