Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor undo/redo handling #586

Open
2 tasks
pcardune opened this issue Nov 16, 2021 · 0 comments
Open
2 tasks

Refactor undo/redo handling #586

pcardune opened this issue Nov 16, 2021 · 0 comments
Labels
code quality Issues that involve improving code quality but don't necessarily contribute to features/bug fixes
Milestone
alpha

Comments

@pcardune
Copy link
Collaborator

There are a few problems with this:

  • undoableAction in the redux store is mutated directly. nothing in the redux store should ever be mutated.
  • it doesn't handle the case when there is no "topmost action" to undo/redo very well. See the call sites for ReadonlyCMBEditor.getTopmostAction for examples.
@pcardune pcardune added the code quality Issues that involve improving code quality but don't necessarily contribute to features/bug fixes label Nov 16, 2021
@pcardune pcardune added this to the alpha milestone Nov 16, 2021
@pcardune pcardune mentioned this issue Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Issues that involve improving code quality but don't necessarily contribute to features/bug fixes
Projects
None yet
Milestone
alpha
Development

No branches or pull requests
1 participant
@pcardune