Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/reimplement search feature #485

Open
pcardune opened this issue Oct 18, 2021 · 2 comments
Open

Fix/reimplement search feature #485

pcardune opened this issue Oct 18, 2021 · 2 comments
Milestone

Comments

@pcardune
Copy link
Collaborator

Depends on #482

It doesn't have any tests and is currently broken. I know we'll need to have search functionality eventually, but is it necessary for the alpha release? If not, we should just disable it for now. AFAIK, the only way to access it is via a keyboard shortcut. Leaving this as a separate issue from #390 since that's just about code quality.

@pcardune pcardune added this to the pre-alpha milestone Oct 18, 2021
@schanzer schanzer modified the milestones: pre-alpha, a11y-beta Oct 20, 2021
@schanzer
Copy link
Member

I think it's fine to delay this for a11y-beta. We'll want to get Sina's take on whatever implementation we come up with, so it's important to have that done in time that.

@pcardune
Copy link
Collaborator Author

ok, so sounds like there are two tasks. One to disable it for now (that should be pre-alpha IMO), and second one to get it working again for a11y-beta. I'll update this task to be the latter and create a new issue for the former.

@pcardune pcardune changed the title Fix or disable search feature Fix/reimplement search feature Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants