Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let preset options be in the form: function(sharpImage) => sharpImage #20

Open
mikestopcontinues opened this issue Dec 2, 2017 · 5 comments
Assignees

Comments

@mikestopcontinues
Copy link

This would allow the user full access to sharp transformations, and would even allow the use of third party transformations (openCV, for instance).

@izaakschroeder
Copy link
Collaborator

izaakschroeder commented Dec 5, 2017

Ah yes! Also an option 😄 I'm working on a hefty refactor right now which you can see in an open pull request I have going. I will see if I can find a way to work this in 🎉 It might be a little bit before I get around to finishing everything though, lots on the go 😞

Thanks for the feedback!

@izaakschroeder izaakschroeder self-assigned this Dec 5, 2017
@mikestopcontinues
Copy link
Author

Woohoo! The refactor is actually why I didn't submit a PR. In any case, I'm looking forward to it!

@izaakschroeder
Copy link
Collaborator

Sorry for the big delay @mikestopcontinues . The refactor is pretty much in! 🎉 There's a little bit of work to do to get the ability to do more transformations, but not a lot. Everything is much cleaner now and you should have a clear point of entry to customize things. In particular processImage can be adjusted to run some kind of pre or post pass for processing. Note that because of another requirement for SSR (people want the generated info but not images) you have to walk a little carefully around what metadata you expect back out.

@mikestopcontinues
Copy link
Author

Just took a look. Looks good! I'm in the process of moving countries, but I hope to send a PR your way sometime in June. Thanks!

@izaakschroeder
Copy link
Collaborator

No problem! 😄Good luck with your move!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants