tree-wide: Clean up our re-exec path #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes the logic for finding the executable path to handle re-execution scenarios. The new bootc_utils::reexec::executable_path() function is a solid approach. My review focuses on a couple of places where this new utility was missed, one of which could lead to a critical runtime failure. Addressing these will make the implementation more robust and consistent with the goals of this change.
cgwalters
force-pushed
the
reexec-cleanup
branch
from
553f58d to
d8034a6
Compare
Prep for fixing bootc-dev#1434 Basically in the selinux path we copy our binary to a tempfile, which breaks `/proc/self/exe`. Fix this by setting an environment variable when we do that re-exec and ensuring that *everything* references an internal API (now moved to utils/ so it can be shared) that looks for the env var first.
cgwalters
force-pushed
the
reexec-cleanup
branch
from
d8034a6 to
d71ec1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep for fixing #1434
Basically in the selinux path we copy our binary to a tempfile, which breaks
/proc/self/exe.Fix this by setting an environment variable when we do that re-exec and ensuring that everything references an internal API (now moved to utils/ so it can be shared) that looks for the env var first.