start moving to systemd service model

Author: jmarrero

crates/lib/src/cli.rs

@@ -485,6 +485,8 @@ pub(crate) enum InternalsOpts {
     /// Initiate a reboot the same way we would after --apply; intended
     /// primarily for testing.
     Reboot,
+    /// Check if soft reboot should be performed and prepare if needed
+    PrepareSoftReboot,
     #[cfg(feature = "rhsm")]
     /// Publish subscription-manager facts to /etc/rhsm/facts/bootc.facts
     PublishRhsmFacts,
@@ -738,6 +740,25 @@ fn can_perform_soft_reboot(deployment: Option<&crate::spec::BootEntry>) -> bool
     deployment.map(|d| d.soft_reboot_capable).unwrap_or(false)
 }
 
+/// If there is staged deployment, check if soft reboot is possible and perform it if possible and return true
+/// else return false
+fn should_soft_reboot(
+    sysroot: &crate::store::Storage,
+    booted_deployment: Option<&ostree::Deployment>,
+) -> Result<bool> {
+    // Get updated status to check for soft-reboot capability
+    let (_deployments, updated_host) = crate::status::get_status(sysroot, booted_deployment)?;
+    
+    // Check if there's a staged deployment that can perform soft reboot
+    if can_perform_soft_reboot(updated_host.status.staged.as_ref()) {
+        soft_reboot_staged(sysroot)?;
+        return Ok(true);
+    }    
+    // TODO check if this reboot is doing a rollback...
+    // TODO then perform a soft reboot for the rollback deployment
+    Ok(false)
+}
+
 /// Prepare and execute a soft reboot for the given deployment
 #[context("Preparing soft reboot")]
 fn prepare_soft_reboot(
@@ -887,9 +908,6 @@ async fn upgrade(opts: UpgradeOpts) -> Result<()> {
             println!("Staged update present, not changed.");
 
             if opts.apply {
-                if can_perform_soft_reboot(host.status.staged.as_ref()) {
-                    soft_reboot_staged(sysroot)?;
-                }
                 crate::reboot::reboot()?;
             }
         } else if booted_unchanged {
@@ -986,12 +1004,6 @@ async fn switch(opts: SwitchOpts) -> Result<()> {
     sysroot.update_mtime()?;
 
     if opts.apply {
-        // Get updated status to check for soft-reboot capability
-        let updated_host = crate::status::get_status(sysroot, Some(&booted_deployment))?.1;
-
-        if can_perform_soft_reboot(updated_host.status.staged.as_ref()) {
-            soft_reboot_staged(sysroot)?;
-        }
         crate::reboot::reboot()?;
     }
 
@@ -1005,20 +1017,6 @@ async fn rollback(opts: RollbackOpts) -> Result<()> {
     crate::deploy::rollback(sysroot).await?;
 
     if opts.apply {
-        // Get status before rollback to check soft-reboot capability
-        let host = crate::status::get_status_require_booted(sysroot)?.2;
-
-        if can_perform_soft_reboot(host.status.rollback.as_ref()) {
-            println!("Rollback deployment is soft-reboot capable, performing soft-reboot...");
-
-            let deployments_list = sysroot.deployments();
-            let target_deployment = deployments_list
-                .first()
-                .ok_or_else(|| anyhow::anyhow!("No deployments found after rollback"))?;
-
-            prepare_soft_reboot(sysroot, target_deployment)?;
-        }
-
         crate::reboot::reboot()?;
     }
 
@@ -1302,6 +1300,17 @@ async fn run_from_opt(opt: Opt) -> Result<()> {
                 }
             },
             InternalsOpts::Reboot => crate::reboot::reboot(),
+            InternalsOpts::PrepareSoftReboot => {
+                let sysroot = &get_storage().await?;
+                let booted_deployment = sysroot.booted_deployment();
+                let should_perform = should_soft_reboot(sysroot, booted_deployment.as_ref())?;
+                if should_perform {
+                    println!("Soft reboot preparation completed");
+                } else {
+                    println!("Soft reboot not needed");
+                }
+                Ok(())
+            }
             InternalsOpts::Fsck => {
                 let sysroot = &get_storage().await?;
                 crate::fsck::fsck(&sysroot, std::io::stdout().lock()).await?;

systemd/bootc-soft-reboot.service

@@ -0,0 +1,17 @@
+[Unit]
+Description=bootc soft reboot preparation
+Documentation=man:bootc(8)
+ConditionPathExists=/run/ostree-booted
+DefaultDependencies=no
+Before=ostree-finalize-staged.service final.target
+Conflicts=final.target
+
+[Service]
+Type=oneshot
+RemainAfterExit=yes
+ExecStart=/bin/true
+ExecStop=/usr/bin/bootc internals prepare-soft-reboot
+TimeoutStopSec=5m
+
+[Install]
+WantedBy=multi-user.target